feat(cli): Add feast projects delete command (closes #5095)#6318
Open
mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
Open
feat(cli): Add feast projects delete command (closes #5095)#6318mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
feast projects delete command (closes #5095)#6318mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
Conversation
Exposes project deletion via the CLI. The new `feast projects delete <name>` command calls store.registry.delete_project() which is already implemented in all concrete registries. - Adds interactive confirmation prompt with --yes/-y flag for scripting - Catches both FeastObjectNotFoundException and ProjectNotFoundException - Exits with code 1 for non-existent projects Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
4 tasks
…tation Addresses Devin Review findings: - Fix project_list: use utils.tags_list_to_dict() instead of manual tag.split(), and print tabulated output matching master - Fix project_current: call store.get_project(name=None) with error handling instead of store.project Both functions now match master branch exactly. Only project_delete is new code from this PR. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Author
|
Thanks for the detailed review, @devin-ai-integration! Fixed both issues in commit 21f7f6a:
The only new code is the |
Author
|
Hi team! Friendly ping on this PR — all 18 CI checks are passing and there are no conflicts with the base branch. This adds a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5095
Exposes project deletion through the CLI by adding a new
feast projects delete <name>subcommand to the existingprojectsgroup.What's changed
Added
project_deletecommand tosdk/python/feast/cli/projects.py:Design notes
store.registry.delete_project(name, commit=True)via the lazy-initregistryproperty (the abstract method exists inBaseRegistryand is implemented in all concrete registries)click.confirm— can be skipped with--yes/-yfor scriptingFeastObjectNotFoundExceptionandProjectNotFoundExceptionso the CLI exits cleanly (exit code 1) for either variant raised by concrete registry implementationsprojects.pyExample
Checklist
deletecommand toprojects_cmdgroup--yesbypass flagprojects.py