feat(cli): Add feast projects delete command#6302
feat(cli): Add feast projects delete command#6302mailtoboggavarapu-coder wants to merge 2 commits intofeast-dev:masterfrom
feast projects delete command#6302Conversation
|
Hi team! 👋 This adds the The implementation directly calls A few design choices I'd love feedback on:
Would appreciate a review when you get a chance! Happy to adjust based on feedback. 🙏 |
|
Thanks for the thorough review, @devin-ai-integration! Fix applied in the latest commit:
|
|
Hi team! 👋 Friendly ping on this PR adding |
|
Hi team! 👋 Friendly ping on this PR adding |
feast projects delete commandfeast projects delete command
|
@mailtoboggavarapu-coder please fix the linting pr checks |
|
Hi team! Checking in on this PR adding the |
Exposes project deletion via the CLI. The new `feast projects delete <name>` command calls `store._registry.delete_project()` which is already implemented in all concrete registries. Adds an interactive confirmation prompt that can be bypassed with --yes/-y for scripted workflows. - Adds type guard (`assert store._registry is not None`) for mypy. - Catches both FeastObjectNotFoundException and ProjectNotFoundException so the CLI exits cleanly (exit code 1) for either variant raised by concrete registry implementations. Squashed history: this commit consolidates the previous unsigned commits on the branch into a single DCO-signed commit, per DCO requirements. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
544d892 to
686a55c
Compare
|
Hi @ntkathole — thanks for the nudge! The PR checks have now been addressed:
Ready for another look whenever you have time — thanks again! |
…t_delete store._registry is always None until accessed via the lazy-init registry property. Using store._registry directly caused project_delete to always crash with an AssertionError. Fixes: Devin Review finding in feast-dev#6302 Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
|
Thanks for the Devin review! Fixed the
The |
|
Closing this PR in favour of #6318 which has a clean single-commit history with a properly matched DCO sign-off (author name = Signed-off-by name). The DCO check was failing here because one commit had |
Summary
Closes #5095
Exposes project deletion through the CLI by adding a new
feast projects delete <name>subcommand to the existingprojectsgroup.What's changed
Added
project_deletecommand tosdk/python/feast/cli/projects.py:Design notes
store._registry.delete_project(name, commit=True)directly sinceFeatureStoredoes not yet expose adelete_projectpublic method (the abstract method exists inBaseRegistryand is implemented in all concrete registries)click.confirm— can be skipped with--yes/-yfor scriptingSystemExit(1)onFeastObjectNotFoundExceptionto match the pattern used bydescribeExample
Checklist
deletecommand toprojects_cmdgroup--yesbypass flagprojects.py