🐛 Improve monorepo application discovery#90
Open
savannahostrowski wants to merge 4 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
So, previously, there were two issues that meant that we weren't properly finding all routes in monorepos:
We only looked in the workspace root for a
pyproject.tomlwhen checking for a configured[tool.fastapi]entrypoint — now we search allpyproject.tomlfiles in the workspace, prioritizing the shallowest one with an entrypoint configuredWhen no
__init__.pywas found in the entry file's directory, we returned early and treated that directory as the project root. This broke namespace packages (PEP 420), which don't use__init__.py. Now we walk up to find apyproject.tomlto anchor the project root instead (this is what directly addresses Cannot find routes in monorepo #89)