Skip to content

fix footer icons shrinking - #2494

Open
ShubhamOulkar wants to merge 3 commits into
expressjs:mainfrom
ShubhamOulkar:fix-footer
Open

fix footer icons shrinking#2494
ShubhamOulkar wants to merge 3 commits into
expressjs:mainfrom
ShubhamOulkar:fix-footer

Conversation

@ShubhamOulkar

@ShubhamOulkar ShubhamOulkar commented Aug 30, 2026

Copy link
Copy Markdown
Member

Footer icons at 320px view port width
image

closes #2456 #2457 #2458

@ShubhamOulkar
ShubhamOulkar requested a review from a team as a code owner August 30, 2026 13:06
@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 752c030
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6a97879a2bcbb50008b3abcf
😎 Deploy Preview https://deploy-preview-2494--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@krzysdz krzysdz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the problem at larger screen sizes when the side menu is open (e.g. after clicking "Docs").

Here's a screenshot at 900 px width:

Docs homepage with the side menu open and showing the "Docs" category. The "Kawaii?" button and social icons overlap with the OpenJS Foundation and Netlify logos.

BTW "Closes #X #Y #Z" won't close all of them - you'll need "closes #X closes #Y closes #Z" for this (GH docs).

@ShubhamOulkar

Copy link
Copy Markdown
Member Author

Here's a screenshot at 900 px width:

Docs homepage with the side menu open and showing the "Docs" category. The "Kawaii?" button and social icons overlap with the OpenJS Foundation and Netlify logos.

Issue #2456 is focused on <400px reported from my phone. I didn't checked all breakpoints thank you for pointing that out. Now I tested on desktop footer social icons starts shrinking from 1060px down to 768px. And on the small screen it starts shrinking at <400px.

Added flex-wrap property to the footer styles for better responsiveness.
@ShubhamOulkar

ShubhamOulkar commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

Fixed in de4c286

manually checked on firefox 900px
Screen Shot 2026-08-31 at 11 08 58

@ShubhamOulkar
ShubhamOulkar requested a review from krzysdz August 31, 2026 05:40

@krzysdz krzysdz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Please change the "closes" in description before merging, because it won't close automatically all referenced issues/PRs (docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

footer: kawaii button shrinking social icons below 400px

2 participants