fix: preserve footer social target sizes - #2457
Conversation
Assisted-by: OpenAI Codex
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi, if this issue is still available, please assign it to me. |
|
This PR already implements the footer fix and is waiting on maintainer review, so the issue is not available to assign. |
| gap: var(--space-6); | ||
|
|
||
| a { | ||
| display: inline-flex; |
There was a problem hiding this comment.
these changes are not required
| color: var(--color-icon-primary); | ||
| width: var(--size-4); | ||
| height: var(--size-4); | ||
| flex-shrink: 0; |
There was a problem hiding this comment.
width and height is not required for icons, already default size is given to icons.
Also I would have put flex-shrink=0 on <li> because they are direct children of flex box <ul>.
|
|
||
| @media (--xs-only) { | ||
| padding: var(--space-4) 0 var(--space-6); | ||
| flex-wrap: wrap; |
There was a problem hiding this comment.
This is right approach but need to add this for all view port widths. see issue #2494 (review)
| await expect(rssLink).toBeVisible(); | ||
| }); | ||
|
|
||
| test('should preserve minimum social icon and target sizes on narrow screens', async ({ |
There was a problem hiding this comment.
I am +1 on adding tests on target sizes for all the buttons and sidebar. Feel free to open PR's for it.
3 participants
Summary
Fixes #2456
Validation
npm run checknpm run test:unit(52 passed)npm run build(2,307 pages built)The complete local homepage run passed all 24 non-locale cases. Its 27 locale-switch cases reproduced the known local dev-server 404 mismatch; the supported Netlify preview workflow will run the complete browser suite.
AI assistance
OpenAI Codex assisted with implementation, test authoring, validation, and pull request preparation.