feat(zigbee): Add color modes support (XY,HSV,TEMP) #12094

P-R-O-C-H-Y · 2025-12-02T13:04:37Z

Description of Change

This pull request adds support for multiple color modes to the ZigbeeColorDimmableLight class, including RGB/XY, HSV, and Color Temperature, with new configuration, control, and callback mechanisms. The documentation and example code have been updated to reflect these enhancements, and new keywords and constants have been added for improved code completion and clarity.

ZigbeeColorDimmableLight color mode support

Added support for multiple color modes (RGB/XY, HSV, Color Temperature) in ZigbeeColorDimmableLight, including new internal attributes, state tracking, and capability configuration. [1] [2]
Introduced mode-specific callback functions (onLightChangeRgb, onLightChangeHsv, onLightChangeTemp) and automatic color mode switching based on the control method used. Legacy onLightChange is now deprecated.
All set/get methods now validate and respect the enabled color capabilities, returning false and logging errors if unsupported operations are attempted. [1] [2] [3]

Documentation and example updates

Expanded documentation to describe new color modes, capabilities, configuration, and callback usage, including practical examples and use cases. [1] [2] [3] [4] [5] [6]
Updated the example Zigbee_Color_Dimmable_Light.ino to demonstrate both RGB and Color Temperature support, including conversion helpers and callback implementations for each mode. [1] [2] [3] [4]

Internal logic and attribute management

Added new attributes for color temperature, min/max temperature, color mode, and capabilities to the Zigbee cluster and internal state, ensuring correct initialization and state restoration. [1] [2]
Refactored attribute setters and event handlers to use the correct callback depending on the current color mode, improving reliability and maintainability.

These changes make the Zigbee color dimmable light endpoint significantly more flexible and robust, supporting a wide range of lighting devices and use cases.

Test Scenarios

Tested using updated example using ESP32C6 and HomeAssistant (ZHA). All options are visible - Level, RGB and Temperature

Related links

Related to #12031
Closes #11654

github-actions · 2025-12-02T13:05:17Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"Apply suggestions from code review"`: summary looks empty type/action looks empty the commit message `"Apply suggestions from code review"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 990eb7b

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2025-12-02T13:29:43Z

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	⚠️ +348	0.00	⚠️ +0.05	0	⚠️ +16	0.00	⚠️ +0.05
ESP32S3	0	⚠️ +224	0.00	⚠️ +0.04	0	0	0.00	0.00
ESP32S2	0	⚠️ +224	0.00	⚠️ +0.04	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	⚠️ +342	0.00	⚠️ +0.06	0	⚠️ +16	0.00	⚠️ +0.05
ESP32H2	0	⚠️ +342	0.00	⚠️ +0.06	0	⚠️ +16	0.00	⚠️ +0.05
ESP32	0	⚠️ +224	0.00	⚠️ +0.04	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/Zigbee/examples/Zigbee_Analog_Input_Output	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Binary_Input_Output	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light	⚠️ +348	⚠️ +16	-	-	-	-	-	-	⚠️ +342	⚠️ +16	⚠️ +342	⚠️ +16	-	-
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Contact_Switch	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Dimmable_Light	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Fan_Control	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Gateway	0	0	⚠️ +224	0	⚠️ +224	0	0	0	-	-	-	-	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_OTA_Client	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_On_Off_Light	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_On_Off_Switch	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_PM25_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Power_Outlet	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Range_Extender	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Scan_Networks	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Temperature_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Thermostat	0	0	⚠️ +224	0	⚠️ +224	0	0	0	0	0	0	0	⚠️ +224	0
libraries/Zigbee/examples/Zigbee_Vibration_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

libraries/Zigbee/keywords.txt

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.h

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp

docs/en/zigbee/ep_color_dimmable_light.rst

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.h

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp

libraries/Zigbee/keywords.txt

github-actions · 2025-12-02T13:37:19Z

Test Results

76 files 76 suites 16m 31s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 990eb7b.

♻️ This comment has been updated with latest results.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.h

…per f

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

libraries/Zigbee/keywords.txt

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feat(zigbee): Add color modes support

502f9fc

P-R-O-C-H-Y self-assigned this Dec 2, 2025

P-R-O-C-H-Y requested a review from pedrominatel as a code owner December 2, 2025 13:04

P-R-O-C-H-Y added this to Arduino ESP32 Core Project Roadmap Dec 2, 2025

P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review Area: Zigbee Issues and Feature Request about Zigbee labels Dec 2, 2025

github-project-automation bot moved this to Todo in Arduino ESP32 Core Project Roadmap Dec 2, 2025

P-R-O-C-H-Y mentioned this pull request Dec 2, 2025

feat(zigbee): Add Temperature Dimmable Light support #12031

Closed

fix(docs): Fix title chars and remove ref

df4d564

P-R-O-C-H-Y requested review from Copilot, lucasssvaz and me-no-dev December 2, 2025 13:08

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Copilot started reviewing on behalf of P-R-O-C-H-Y December 2, 2025 13:29 View session

P-R-O-C-H-Y requested a review from Copilot December 2, 2025 13:29

Copilot finished reviewing on behalf of P-R-O-C-H-Y December 2, 2025 13:31

Copilot started reviewing on behalf of P-R-O-C-H-Y December 2, 2025 13:33 View session

Copilot finished reviewing on behalf of P-R-O-C-H-Y December 2, 2025 13:35

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Apply suggestions from code review

59de367

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

me-no-dev reviewed Dec 3, 2025

View reviewed changes

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.h Outdated Show resolved Hide resolved

P-R-O-C-H-Y added 2 commits December 3, 2025 13:23

feat(zigbee): Use contexpr, cb typedefs, cb simplification

d9c8245

feat(zigbee): Dont force XY mode for state and level change + add hel…

c6b6023

…per f

P-R-O-C-H-Y requested review from Copilot and me-no-dev December 3, 2025 12:33

P-R-O-C-H-Y moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Dec 3, 2025

me-no-dev approved these changes Dec 3, 2025

View reviewed changes

Copilot started reviewing on behalf of P-R-O-C-H-Y December 3, 2025 13:02 View session

Copilot finished reviewing on behalf of P-R-O-C-H-Y December 3, 2025 13:04

Copilot AI reviewed Dec 3, 2025

View reviewed changes

libraries/Zigbee/keywords.txt Outdated Show resolved Hide resolved

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp Outdated Show resolved Hide resolved

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp Outdated Show resolved Hide resolved

P-R-O-C-H-Y and others added 3 commits December 3, 2025 14:49

Apply suggestions from code review

39f4152

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'master' into feat/zigbee-colorlight-modes

a934e88

fix(zigbee): Remove on_light_change from constructor

990eb7b

lucasssvaz approved these changes Dec 3, 2025

View reviewed changes

feat(zigbee): Add color modes support (XY,HSV,TEMP) #12094

Are you sure you want to change the base?

feat(zigbee): Add color modes support (XY,HSV,TEMP) #12094

Conversation

P-R-O-C-H-Y commented Dec 2, 2025

Description of Change

ZigbeeColorDimmableLight color mode support

Documentation and example updates

Internal logic and attribute management

Test Scenarios

Related links

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage test (comparing PR against master branch)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading