feat(zigbee): Add Temperature Dimmable Light support #12031

Hannes-Beckmann · 2025-11-15T12:09:17Z

Description of Change

This pull request introduces a new Zigbee Temperature Dimmable Light endpoint.

Test Scenarios

I have tested this Pull Request with pioarduino with the esp32-c6-devkitm-1 board on an ESP32-C6-MINI-1U using the ZHA-Integration in Home Assistant.
The included example is not tested since I do not have access to a board with a built-in RGB-LED.

Note that the minimum and maximum temperature is not respected by Home Assistant. Out of range values are clamped.

CLAassistant · 2025-11-15T12:09:23Z

All committers have signed the CLA.

github-actions · 2025-11-15T12:09:56Z

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message `"Add Temperature Dimmable Light"`: summary looks empty type/action looks empty the commit message `"Add documentation"`: summary looks empty type/action looks empty the commit message `"Add example"`: summary looks empty type/action looks empty the commit message `"Test to use the right Core"`: summary looks empty type/action looks empty the commit message `"Undo test"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: `<type/action>(<scope/component>): <summary>`, for example `fix(esp32): Fixed startup timeout issue` allowed types are: `change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Hannes-Beckmann, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e046998

P-R-O-C-H-Y

Hi @Hannes-Beckmann, thank you for your addition to the Zigbee Library.
I have tested using a HA (ZHA) and a C6 with RGB light and it works as a charm.

I have requested a few changes to make the API as close to the other Light endpoints.

P-R-O-C-H-Y · 2025-11-18T11:29:39Z

docs/en/zigbee/ep_temperature_dimmable_light.rst

+###############################
+ZigbeeTemperatureDimmableLight
+###############################


Formatting issue

Suggested change

###############################

ZigbeeTemperatureDimmableLight

###############################

##############################

ZigbeeTemperatureDimmableLight

##############################

P-R-O-C-H-Y · 2025-11-18T11:33:57Z

docs/en/zigbee/ep_temperature_dimmable_light.rst

+setColorTemperature
+^^^^^^^^^^^^^^^^^^^
+
+Sets the light color temperature (in mireds).
+
+.. code-block:: arduino
+
+    bool setColorTemperature(uint16_t mireds);
+
+* ``mireds`` - Color temperature in mireds (153 = 6500K, 500 = 2000K)
+
+Returns ``true`` if successful, ``false`` otherwise.


Update to preferred API change

Suggested change

setColorTemperature

^^^^^^^^^^^^^^^^^^^

Sets the light color temperature (in mireds).

.. code-block:: arduino

bool setColorTemperature(uint16_t mireds);

* ``mireds`` - Color temperature in mireds (153 = 6500K, 500 = 2000K)

Returns ``true`` if successful, ``false`` otherwise.

setLightTemperature

^^^^^^^^^^^^^^^^^^^

Sets the light color temperature (in mireds).

.. code-block:: arduino

bool setLightTemperature(uint16_t mireds);

* ``mireds`` - Color temperature in mireds (153 = 6500K, 500 = 2000K)

Returns ``true`` if successful, ``false`` otherwise.

P-R-O-C-H-Y · 2025-11-18T11:34:57Z

docs/en/zigbee/ep_temperature_dimmable_light.rst

+getColorTemperature
+^^^^^^^^^^^^^^^^^^^
+
+Gets the current color temperature (in mireds).
+
+.. code-block:: arduino
+
+    uint16_t getColorTemperature();
+
+Returns current color temperature in mireds.


Suggested change

getColorTemperature

^^^^^^^^^^^^^^^^^^^

Gets the current color temperature (in mireds).

.. code-block:: arduino

uint16_t getColorTemperature();

Returns current color temperature in mireds.

getLightTemperature

^^^^^^^^^^^^^^^^^^^

Gets the current color temperature (in mireds).

.. code-block:: arduino

uint16_t getLightTemperature();

Returns current color temperature in mireds.

P-R-O-C-H-Y · 2025-11-18T11:36:56Z

...ries/Zigbee/examples/Zigbee_Temperature_Dimmable_Light/Zigbee_Temperature_Dimmable_Light.ino

+
+#include "Zigbee.h"
+
+#define ZIGBEE_TEMP_LIGHT_ENDPOINT 11


Start from endpoint number 1. No need to be using number 11

Suggested change

#define ZIGBEE_TEMP_LIGHT_ENDPOINT 11

#define ZIGBEE_TEMP_LIGHT_ENDPOINT 1

P-R-O-C-H-Y · 2025-11-18T11:37:11Z

...ries/Zigbee/examples/Zigbee_Temperature_Dimmable_Light/Zigbee_Temperature_Dimmable_Light.ino

+ * @brief This example demonstrates Zigbee Temperature Dimmable light bulb.
+ *
+ * The example demonstrates how to use Zigbee library to create an end device with
+ * temperature dimmable light end point.


Suggested change

* temperature dimmable light end point.

* temperature dimmable light endpoint.

P-R-O-C-H-Y · 2025-11-18T11:39:35Z

libraries/Zigbee/src/Zigbee.h

 #include "ep/ZigbeeSwitch.h"
 //// Lights
 #include "ep/ZigbeeColorDimmableLight.h"
+#include "ep/ZigbeeTemperatureDimmableLight.h"


Nitpick here, please use Alphabetical order, so place it on last place in Lights group

P-R-O-C-H-Y · 2025-11-18T11:41:04Z

libraries/Zigbee/src/ep/ZigbeeTemperatureDimmableLight.cpp

+bool ZigbeeTemperatureDimmableLight::setColorTemperature(uint16_t mireds) {
+  return setLight(_current_state, _current_level, mireds);
+}


I would prefer the setLightTemperature method name instead.

Suggested change

bool ZigbeeTemperatureDimmableLight::setColorTemperature(uint16_t mireds) {

return setLight(_current_state, _current_level, mireds);

}

bool ZigbeeTemperatureDimmableLight::setLightTemperature(uint16_t mireds) {

return setLight(_current_state, _current_level, mireds);

}

P-R-O-C-H-Y · 2025-11-18T11:41:50Z

libraries/Zigbee/src/ep/ZigbeeTemperatureDimmableLight.h

+
+  bool setLightState(bool state);
+  bool setLightLevel(uint8_t level);
+  bool setColorTemperature(uint16_t mireds);


I would prefer the setLightTemperature API name instead

Suggested change

bool setColorTemperature(uint16_t mireds);

bool setLightTemperature(uint16_t mireds);

P-R-O-C-H-Y · 2025-11-18T11:42:28Z

libraries/Zigbee/src/ep/ZigbeeTemperatureDimmableLight.h

+  uint16_t getColorTemperature() {
+    return _current_color_temperature;
+  }


Same here, will prefer the getLightTemperature instead.

Suggested change

uint16_t getColorTemperature() {

return _current_color_temperature;

}

uint16_t getLightTemperature() {

return _current_color_temperature;

}

github-actions · 2025-11-18T11:47:29Z

Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit e046998.

Hannes-Beckmann and others added 6 commits November 11, 2025 18:05

Test to use the right Core

cfc72f6

Undo test

c32846c

Add Temperature Dimmable Light

fa081b8

Add example

78a489e

Merge branch 'espressif:master' into master

9682e0d

Add documentation

e046998

Hannes-Beckmann requested review from P-R-O-C-H-Y, lucasssvaz and pedrominatel as code owners November 15, 2025 12:09

me-no-dev assigned P-R-O-C-H-Y Nov 17, 2025

P-R-O-C-H-Y requested changes Nov 18, 2025

View reviewed changes

P-R-O-C-H-Y added Area: Zigbee Issues and Feature Request about Zigbee Status: Awaiting Response Awaiting a response from the author labels Nov 18, 2025

	#define ZIGBEE_TEMP_LIGHT_ENDPOINT 11
	#define ZIGBEE_TEMP_LIGHT_ENDPOINT 1

	* temperature dimmable light end point.
	* temperature dimmable light endpoint.

	bool setColorTemperature(uint16_t mireds);
	bool setLightTemperature(uint16_t mireds);

feat(zigbee): Add Temperature Dimmable Light support #12031

Are you sure you want to change the base?

feat(zigbee): Add Temperature Dimmable Light support #12031

Conversation

Hannes-Beckmann commented Nov 15, 2025

Description of Change

Test Scenarios

Uh oh!

CLAassistant commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 18, 2025

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented Nov 15, 2025 •

edited

Loading