Skip to content

fix(ble): Add missing modifier keys for HID Keyboard #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −3
Open

fix(ble): Add missing modifier keys for HID Keyboard #12093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7690712
fix(ble): Add missing modifier keys for HID Keyboard
lucasssvaz Dec 2, 2025
78f8552
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions libraries/BLE/src/HIDKeyboardTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,28 @@
#ifndef KEYBOARD_DEFS_H
#define KEYBOARD_DEFS_H

#include "esp_bit_defs.h"

#define REPORT_ID_KEYBOARD 1
#define REPORT_ID_VOLUME 3

/* Modifiers */
enum MODIFIER_KEY {
KEY_CTRL = 1,
KEY_SHIFT = 2,
KEY_ALT = 4,
/* Aliases for the left modifiers */
KEY_CTRL = BIT(0),
KEY_SHIFT = BIT(1),
KEY_ALT = BIT(2),
KEY_GUI = BIT(3), /*!< GUI key (Command on macOS, Windows key on Windows) */
/* Left modifiers */
KEY_LEFT_CTRL = BIT(0),
KEY_LEFT_SHIFT = BIT(1),
KEY_LEFT_ALT = BIT(2),
KEY_LEFT_GUI = BIT(3),
/* Right modifiers */
KEY_RIGHT_CTRL = BIT(4),
KEY_RIGHT_SHIFT = BIT(5),
KEY_RIGHT_ALT = BIT(6),
KEY_RIGHT_GUI = BIT(7),
};

enum MEDIA_KEY {
Expand Down
Loading