Skip to content

Conversation

@lucasssvaz
Copy link
Member

Description of Change

This pull request updates the HIDKeyboardTypes.h header to improve clarity and flexibility in handling keyboard modifier keys. The main focus is on expanding and clarifying the definitions of modifier keys, introducing both left and right variants, and using bitwise definitions for better compatibility.

Modifier key improvements:

  • Switched modifier key definitions from fixed integer values to use the BIT() macro, making them clearer and more maintainable. (KEY_CTRL, KEY_SHIFT, KEY_ALT)
  • Added explicit definitions for left and right modifier keys (KEY_LEFT_CTRL, KEY_RIGHT_CTRL, etc.), and included the GUI (Windows/Command) key for both sides.
  • Included the esp_bit_defs.h header to provide the BIT() macro used in the new definitions.

Related links

Closes #12084

@lucasssvaz lucasssvaz requested a review from SuGlider as a code owner December 2, 2025 12:44
@lucasssvaz lucasssvaz self-assigned this Dec 2, 2025
@lucasssvaz lucasssvaz added the Area: BLE Issues related to BLE label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 78f8552

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Test Results

 76 files   76 suites   18m 2s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 78f8552.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: BLE Issues related to BLE Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GUI (Command) Key missed in /libraries/BLE/src/HIDKeyboardTypes.h

3 participants