fix(ble): Add missing modifier keys for HID Keyboard #12093
+17
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request updates the
HIDKeyboardTypes.hheader to improve clarity and flexibility in handling keyboard modifier keys. The main focus is on expanding and clarifying the definitions of modifier keys, introducing both left and right variants, and using bitwise definitions for better compatibility.Modifier key improvements:
BIT()macro, making them clearer and more maintainable. (KEY_CTRL,KEY_SHIFT,KEY_ALT)KEY_LEFT_CTRL,KEY_RIGHT_CTRL, etc.), and included the GUI (Windows/Command) key for both sides.esp_bit_defs.hheader to provide theBIT()macro used in the new definitions.Related links
Closes #12084