Skip to content

Add a ChangeLog entry about the version of Java used by current Closure #26929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juj wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

Add a ChangeLog entry about the version of Java used by current Closure #26929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae5412
Add a ChangeLog entry about the version of Java used by current Closu…
juj May 12, 2026
7e1535b
Update wording
juj May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ See docs/process.md for more on how version tagging works.
callback `IDBFS.onAutoPersistStateChanged = active => {}`, which will be
notified of all IDBFS sync start and end events. (#26895)
- google-closure-compiler was updated to 20260429.0.0. (#26869)
Closure compiler now provides a native macOS arm64 binary for Apple Silicon.
Closure compiler now provides a native macOS arm64 binary for Apple Silicon,
in addition to having native binaries for Win-x64, Linux-x64 and Linux-ARM64.
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the "Linux-x64 and Linux-ARM64" part is true.. I think I remember seeing that the npm package has just one arch per OS?

Copy link
Copy Markdown
Collaborator Author

@juj juj May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder..

I went based on https://github.com/ChadKillingsworth/closure-compiler-npm, which states

image

Copy link
Copy Markdown
Collaborator Author

@juj juj May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ChadKillingsworth/closure-compiler-npm/blob/606318e0216c553438b8d72b68fee2cda2d7d153/build-scripts/build-compiler.js#L67-L90 at least builds two for Linux.

For other platforms for which Closure compiler does not ship a native binary,
e.g. Intel x64 Macs and Windows-on-ARM, downloading Java SE Development Kit
21.0.11 from https://www.oracle.com/europe/java/technologies/downloads/#java21
is required in order to use Emscripten's Closure Compiler integration.

5.0.7 - 04/30/26
----------------
Expand Down
Loading