Add a ChangeLog entry about the version of Java used by current Closure#26929
Open
juj wants to merge 2 commits into
Open
Add a ChangeLog entry about the version of Java used by current Closure#26929juj wants to merge 2 commits into
juj wants to merge 2 commits into
Conversation
…re version, and a note of when installing Java is necessary.
sbc100
reviewed
May 12, 2026
| notified of all IDBFS sync start and end events. (#26895) | ||
| - google-closure-compiler was updated to 20260429.0.0. (#26869) | ||
| Closure compiler now provides a native macOS arm64 binary for Apple Silicon. | ||
| (In addition to having native binaries for Win-x64, Linux-x64 and Linux-ARM64) |
Collaborator
There was a problem hiding this comment.
Should this be part of the previous sentence?
Collaborator
Author
There was a problem hiding this comment.
Updated wording. How about now?
sbc100
approved these changes
May 12, 2026
sbc100
reviewed
May 12, 2026
| - google-closure-compiler was updated to 20260429.0.0. (#26869) | ||
| Closure compiler now provides a native macOS arm64 binary for Apple Silicon. | ||
| Closure compiler now provides a native macOS arm64 binary for Apple Silicon, | ||
| in addition to having native binaries for Win-x64, Linux-x64 and Linux-ARM64. |
Collaborator
There was a problem hiding this comment.
I'm not sure the "Linux-x64 and Linux-ARM64" part is true.. I think I remember seeing that the npm package has just one arch per OS?
Collaborator
Author
There was a problem hiding this comment.
Hmm, I wonder..
I went based on https://github.com/ChadKillingsworth/closure-compiler-npm, which states
Collaborator
Author
There was a problem hiding this comment.
sbc100
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ChangeLog entry about the version of Java used by current Closure version, and a note of when installing Java is necessary.
Attempting to use Java 20 or older will produce an error like
http://clbri.com:8010/api/v2/logs/433679/raw_inline