chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 - #23
chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4#23dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@v2.4.3...v2.4.4) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-version: 2.4.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
srpatcha
left a comment
There was a problem hiding this comment.
Review — eBrowser#23 "chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4"
head: 93cfab3 author: app/dependabot ci: none ran
Verdict: A one-line patch bump of a workflow the repo already runs successfully, and
the safest of the three eBrowser dependency PRs. Two things to be aware of before merging:
no check ran on it (same traced cause as #21 and #22), and the upstream release
deliberately converts one class of failure into a log line.
Findings
| # | Severity | File:line | Finding | Recommended fix |
|---|---|---|---|---|
| 1 | Medium | .github/workflows/ci.yml:8 (at base b21abf9c) |
No CI ran on this PR — gh pr checks 23 returns one entry, assign skipping. Root cause, verified: at base b21abf9c the ci.yml trigger was pull_request: branches: [main] while this PR targets master, so the workflow never matched. master fixed this in #20 (bb37c5b) with branches: [master, main]; the PR is 4 commits behind. Lower severity than on #21/#22 because scorecard.yml is push/schedule-triggered and would not have run on a PR in any case — but the repo's own test matrix should still have. |
Rebase onto origin/master. The bump itself is only exercised by the Monday cron or workflow_dispatch after merge; run it manually once to confirm. |
| 2 | Low | .github/workflows/scorecard.yml:28-32 |
The upstream v2.4.4 release notes list "log POST failures instead of failing entire action" (ossf/scorecard-action#1625). Because this job sets publish_results: true, a failure to publish the score to the Scorecard API will, after this bump, be logged instead of failing the job. .github/STANDARDS.md:62 lists OpenSSF Scorecard as an org-wide framework and STANDARDS.md:100-106 says a claim is aspirational unless a verifying workflow runs on every push — a silently-not-publishing job would leave the public score stale while the workflow stays green. Scope is narrow: the Upload SARIF step at scorecard.yml:33-36 still fails if results.sarif was not produced, so local SARIF generation remains gated. Only the public POST becomes non-fatal. |
Merge it — this is upstream's decision and the alternative is a flaky job — but be aware the green tick no longer means "score published". If the public score matters for the STANDARDS.md claim, add a step that asserts the publish succeeded, or check the score date periodically. |
| 3 | Low | (repo-wide) | .github/dependabot.yml is absent from master; Dependabot was disabled org-wide (eDB's eaf4e1c: "config removed here, and alerts plus automated security fixes turned off via the API. 90 open Dependabot PRs"). This PR is an orphan — nothing will rebase or supersede it, and the same bump will not be re-proposed if it is closed. The bot's github-actions label comment is moot. |
Merge after rebase, or close and record the bump manually. |
Note for sequencing: eBrowser#22 also edits .github/workflows/scorecard.yml (line 24,
actions/checkout@v4 → @v7). Different lines, so no textual conflict, but the two PRs
touch the same file and whichever lands second will need a rebase.
Compatibility check on the bump itself
v2.4.3 → v2.4.4 is a patch bump (published 2026-07-23), and its notes describe exactly
two things: the underlying Scorecard moves to v5.5.0, and the POST-failure behaviour in
finding 2. No input was renamed or removed — results_file, results_format and
publish_results are all still valid, and scorecard.yml:29-32 passes only those three.
The permissions: block at scorecard.yml:19-21 (security-events: write,
id-token: write) is unchanged and still what the action requires.
Evidence the baseline works: gh run list --workflow scorecard.yml shows the four most
recent OSSF Scorecard runs on master all concluding success.
Architecture conformance
Not applicable in the layering sense — one line in .github/workflows/scorecard.yml; no
#include, import, link line or manifest dependency, so §5.1 cannot be violated.
eBrowser is Tier 5 (Applications) per §21; §20.1 keeps it a reference application.
§21.1 untouched. The change is squarely inside the "Infrastructure" row of §21
(governance, release automation) as applied within a product repo.
Proposed changes
- Rebase onto current
master(finding 1), then merge. - After merge, trigger
scorecard.ymlviaworkflow_dispatchonce so v2.4.4 is
actually exercised rather than waiting for Monday's cron. - Decide whether the public score needs an explicit publish assertion (finding 2).
Not checked
- Whether v2.4.4 runs green in this repo.
scorecard.ymldoes not trigger on
pull_request, so nothing has executed the new version here. The success evidence
above is for v2.4.3 onmaster. - Scorecard v5.4.0 / v5.5.0 check changes. The release notes delegate to two upstream
Scorecard releases that I did not read. The repo's score may move for reasons unrelated
to any code change; I cannot say in which direction. - Whether the published score is currently up to date. Not queried.
- The rest of
scorecard.yml. Reviewed only around the changed line, plus the
permissionsandUpload SARIFsteps needed to judge finding 2.
Automated architecture review of 93cfab303627 — scheduled, model claude-opus-5, checked against the EmbeddedOS Master Design v2.0. Advisory only: this reviewer never approves, requests changes, or merges. Reply here to discuss or push back — a wrong finding is a bug worth reporting.
Bumps ossf/scorecard-action from 2.4.3 to 2.4.4.
Release notes
Sourced from ossf/scorecard-action's releases.
Commits
2d11466Bump action tag for v2.4.4 release (#1688)1bd3285🌱 Bump the docker-images group across 1 directory with 2 updates (#1...913edce🌱 Bump github.com/containerd/containerd from 1.7.32 to 1.7.33 (#1671)0957b8f🌱 Bump golang.org/x/net from 0.56.0 to 0.57.0 (#1680)f0061eb🌱 Bump google.golang.org/grpc from 1.81.1 to 1.82.1 (#1687)20ee732🌱 Bump github.com/sigstore/cosign/v2 from 2.6.3 to 2.6.4 (#1685)9f295ef🌱 Bump the github-actions group with 6 updates (#1686)69bf556🌱 Bump github.com/sigstore/sigstore-go from 1.1.4 to 1.2.0 (#1681)94e8b96🌱 Bump github.com/sigstore/rekor from 1.5.0 to 1.5.2 (#1673)c7a1b37🌱 Bump github.com/sigstore/fulcio from 1.8.5 to 1.8.6 (#1675)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)