chore(deps): bump codecov/codecov-action from 4 to 7 - #21
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 7. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v7) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
added
dependencies
dependabot
Bot
added
major
srpatcha
reviewed
Sep 4, 2026
srpatcha
left a comment
srpatcha
left a comment
Member
There was a problem hiding this comment.
Review — eBrowser#21 "chore(deps): bump codecov/codecov-action from 4 to 7"
head: f0b23af author: app/dependabot ci: none ran
Verdict: One-line bump, and the one input that v5 renamed is already correct here, so
the migration risk is nil. Same blocker as its sibling PRs: no check ran, for a reason I
traced. Separately, the step this PR is bumping cannot fail and discards its own result,
which makes the upgrade cosmetic until that is fixed.
Findings
| # | Severity | File:line | Finding | Recommended fix |
|---|---|---|---|---|
| 1 | High | .github/workflows/ci.yml:8 (at base b21abf9c) |
No CI ran on this PR. gh pr checks 21 returns one entry — assign skipping. Root cause, verified: at base b21abf9c, ci.yml's trigger was pull_request: branches: [main] while this PR targets master, so the workflow never matched. master has since been fixed by #20 (bb37c5b) to branches: [master, main]; the PR is 4 commits behind. Since the changed step lives inside that very workflow, nothing has executed the new action version. |
Rebase onto origin/master; CI will then trigger and the upload step will actually run. |
| 2 | Medium | .github/workflows/ci.yml:57-60 |
The step being upgraded discards its result. There is no fail_ci_if_error, so it defaults to false and a failed upload is a green step. It is also fed by steps that cannot fail: ci.yml:38 (ruff), :42 (mypy) and :55 (benchmarks) all carry continue-on-error: true. Per .ai/reviewer.md, a verification whose result is discarded is a finding regardless of the reason. Upgrading v4 → v7 changes nothing observable while that holds. |
Add fail_ci_if_error: true to the Upload coverage step. Separately, drop continue-on-error: true from the ruff and mypy steps or move them to a job that is allowed to fail on purpose — a lint step that cannot fail is not a lint step. |
| 3 | Medium | repo setting: branches/master/protection |
required_status_checks: null on master. Reviews are required; no check is. Finding 1 therefore does not block a merge, and CI — eBrowser currently concluding failure on master does not either. |
Set required status checks on master with strict: true. |
| 4 | Low | .github/workflows/ci.yml (file mode) |
The diff also flips the file mode 100755 → 100644. Harmless and arguably right — a workflow YAML has no reason to be executable — but it is an unrelated change riding in a dependency bump, and the PR body does not mention it. |
Nothing to fix; noting it so it is not mistaken later for an unexplained mode change. |
| 5 | Low | (repo-wide) | .github/dependabot.yml is absent from master; Dependabot was disabled org-wide (eDB's eaf4e1c: "config removed here, and alerts plus automated security fixes turned off via the API. 90 open Dependabot PRs"). This PR is an orphan — nothing will rebase or supersede it. The bot's github-actions label comment is moot. |
Merge after rebase, or close and record the bump as a manual to-do. |
Compatibility check on the bump itself
v4 → v7 skips two majors:
- v5.0.0 — the action was rewritten around the Codecov CLI wrapper. Its migration
notice deprecatesfilein favour offilesandpluginin favour ofplugins.
This workflow already usesfiles: coverage.xml(ci.yml:60), so the one renamed
input that applies here needs no change. v5 also coincides with tokenless upload for
public repositories; the current v4 step passes notokeneither, so the auth posture
is unchanged by this PR. - v6.0.0 — moves to node24; the release notes flag this as potentially breaking "for
systems that do not currently support node24". All jobs here are GitHub-hosted
(ubuntu-22.04,macos-13,windows-2022) andgrep -rn "self-hosted" .github/workflows/
returns nothing. - v7.0.0 — no breaking changes listed.
codecov/codecov-action@v7.0.0 exists (published 2026-06-07). The diff is a single line.
Architecture conformance
Not applicable in the layering sense — one line in .github/workflows/ci.yml; no
#include, import, link line or manifest dependency, so §5.1 cannot be violated.
eBrowser is Tier 5 (Applications) per §21; §20.1 keeps it a reference application, and
nothing here changes that. §21.1 untouched.
Proposed changes
- Rebase onto current
master(finding 1). - In the same PR or a follow-up, add
fail_ci_if_error: truetoci.yml:57-60
(finding 2). Without it this upgrade cannot be observed to work or not work. - Configure required status checks on
master(finding 3). - Handle the ruff/mypy
continue-on-error: trueatci.yml:38and:42as a separate
change — it is outside this diff but it is why coverage and lint signal are both inert.
Findings 1, 3 and 5 apply identically to eBrowser#22 and #23; they share the base commit.
Not checked
- Whether the upgraded action uploads successfully. No job ran on this head. I have
not seen a v7 upload succeed against this repo's Codecov configuration. - The Codecov project settings. Whether the org has enabled the "Global Upload Token"
opt-out that tokenless public-repo uploads rely on is not visible from the repository,
and I did not query Codecov. If it is not enabled, uploads may already be failing
silently — which finding 2 would be hiding. - Coverage numbers. Not examined;
coverage.xmlis produced byci.yml:44-46, which
has not run on this head. - The rest of
ci.yml. Reviewed only around the changed line.
Automated architecture review of f0b23af0436d — scheduled, model claude-opus-5, checked against the EmbeddedOS Master Design v2.0. Advisory only: this reviewer never approves, requests changes, or merges. Reply here to discuss or push back — a wrong finding is a bug worth reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps codecov/codecov-action from 4 to 7.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
fb8b358chore(release): 7.0.0 (#1957)ca0a928ci: remove Enforce License Compliance workflow (#1950)e79a696chore(release): 6.0.1 (#1949)51e6422fix: prevent template injection in run: steps (VULN-1652) (#1947)57e3a13Th/6.0.0 (#1928)f67d33dRevert "Revert "build(deps): bump actions/github-script from 7.0.1 to 8.0.0""...75cd116chore(release): 5.5.4 (#1927)87d39f4Revert "build(deps): bump actions/github-script from 7.0.1 to 8.0.0" (#1926)1af5884chore(release): bump to 5.5.3 (#1922)c143300build(deps): bump actions/github-script from 7.0.1 to 8.0.0 (#1874)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)