Repository navigation
build(deps-dev): bump @electron-forge/plugin-vite from 8.0.0-alpha.10 to 8.0.1 #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/electron-forge/plugin-vite-8.0.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−13
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟣 pre-existing, not blocking: pre-existing: CI installs with
yarn install --immutablewill probably still fail. The lockfile has dangling references, and this bump adds one more. The new plugin-vite entry needs@ electron-forge/shared-types@ npm:8.0.1, but yarn.lock has no resolution block for that descriptor. Only the8.0.0-alpha.10block exists at yarn.lock:567.@ electron-forge/maker-base@ npm:8.0.1is also missing. Fix: rerunyarn installso every referenced Forge 8.0.1 descriptor gets its own entry, then commit the complete lockfile.A small fix can ride a push you are already making; otherwise a short reply is enough.
Why this was flagged
The new
@ electron-forge/plugin-vite@ npm:8.0.1entry at yarn.lock:528-539 depends on@ electron-forge/shared-types: npm:8.0.1(yarn.lock:534). No"@ electron-forge/shared-types@ npm:8.0.1"block exists anywhere in yarn.lock; the only one is8.0.0-alpha.10at yarn.lock:567.@ electron-forge/maker-base@ npm:8.0.1is referenced by maker-squirrel (yarn.lock:476) and has no entry either. CI and release runyarn install --immutable(.github/workflows/ci.yml:56, :138, release.yml:57, :127, :220). Yarn has to add the missing resolutions, and immutable mode rejects that, so the install step fails. The base lockfile already had the same gap through core-utils, plugin-base, plugin-fuses and maker-squirrel 8.0.1, so this is pre-existing. The PR says the lockfile was regenerated, yet it adds another dangling reference instead of fixing the gap.Verification: Pre-existing. Trigger:
yarn install --immutable, which CI runs at .github/workflows/ci.yml:56. The new block at yarn.lock:528-539 lists"@ electron-forge/shared-types": "npm:8.0.1". There is noshared-types@ npm:8.0.1block. Yarn has to resolve these descriptors, which means rewriting the lockfile, and--immutablerejects that. The base lockfile (7aeea3b) was already broken the same way.