Repository navigation
build(deps-dev): bump @electron-forge/plugin-vite from 8.0.0-alpha.10 to 8.0.1 - #2070
dependabot[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@electron-forge/plugin-vite@npm:8.0.1": | ||
| version: 8.0.1 | ||
| resolution: "@electron-forge/plugin-vite@npm:8.0.1" | ||
| dependencies: | ||
| "@electron-forge/core-utils": "npm:8.0.0-alpha.10" | ||
| "@electron-forge/plugin-base": "npm:8.0.0-alpha.10" | ||
| "@electron-forge/shared-types": "npm:8.0.0-alpha.10" | ||
| "@electron-forge/core-utils": "npm:8.0.1" | ||
| "@electron-forge/plugin-base": "npm:8.0.1" | ||
| "@electron-forge/shared-types": "npm:8.0.1" |
There was a problem hiding this comment.
🟣 pre-existing, not blocking: pre-existing: CI installs with yarn install --immutable will probably still fail. The lockfile has dangling references, and this bump adds one more. The new plugin-vite entry needs @ electron-forge/shared-types@ npm:8.0.1, but yarn.lock has no resolution block for that descriptor. Only the 8.0.0-alpha.10 block exists at yarn.lock:567. @ electron-forge/maker-base@ npm:8.0.1 is also missing. Fix: rerun yarn install so every referenced Forge 8.0.1 descriptor gets its own entry, then commit the complete lockfile.
A small fix can ride a push you are already making; otherwise a short reply is enough.
Why this was flagged
The new @ electron-forge/plugin-vite@ npm:8.0.1 entry at yarn.lock:528-539 depends on @ electron-forge/shared-types: npm:8.0.1 (yarn.lock:534). No "@ electron-forge/shared-types@ npm:8.0.1" block exists anywhere in yarn.lock; the only one is 8.0.0-alpha.10 at yarn.lock:567. @ electron-forge/maker-base@ npm:8.0.1 is referenced by maker-squirrel (yarn.lock:476) and has no entry either. CI and release run yarn install --immutable (.github/workflows/ci.yml:56, :138, release.yml:57, :127, :220). Yarn has to add the missing resolutions, and immutable mode rejects that, so the install step fails. The base lockfile already had the same gap through core-utils, plugin-base, plugin-fuses and maker-squirrel 8.0.1, so this is pre-existing. The PR says the lockfile was regenerated, yet it adds another dangling reference instead of fixing the gap.
Verification: Pre-existing. Trigger: yarn install --immutable, which CI runs at .github/workflows/ci.yml:56. The new block at yarn.lock:528-539 lists "@ electron-forge/shared-types": "npm:8.0.1". There is no shared-types@ npm:8.0.1 block. Yarn has to resolve these descriptors, which means rewriting the lockfile, and --immutable rejects that. The base lockfile (7aeea3b) was already broken the same way.
Bumps [@electron-forge/plugin-vite](https://github.com/electron/forge/tree/HEAD/packages/plugin/vite) from 8.0.0-alpha.10 to 8.0.1. - [Release notes](https://github.com/electron/forge/releases) - [Changelog](https://github.com/electron/forge/blob/main/CHANGELOG.md) - [Commits](https://github.com/electron/forge/commits/v8.0.1/packages/plugin/vite) --- updated-dependencies: - dependency-name: "@electron-forge/plugin-vite" dependency-version: 8.0.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
f5c8947 to
1dead75
Compare
Bumps @electron-forge/plugin-vite from 8.0.0-alpha.10 to 8.0.1.
Release notes
Sourced from @electron-forge/plugin-vite's releases.
... (truncated)
Changelog
Sourced from @electron-forge/plugin-vite's changelog.
... (truncated)
Commits
48f38bbchore: bump version to 8.0.1 (#4426)40b4adfchore: bump version to 8.0.0 (#4425)1d268aabuild(deps): bump vulnerable transitive and direct dependencies (#4408)c012507feat(bundlers)!: emit main and preload bundles as .cjs (#4393)29f5980chore(deps)!: upgrade listr2 to v11 (#4375)5166ca9feat(plugin-vite): graduate from experimental (#4382)99ef7bebuild(deps): bump @electron/* and electron-installer-* packages (#4379)b52f517feat(template)!: unify JS/TS templates (#4229)f9c705dfeat(plugin-vite): support custom server host in renderer dev server URL (#4363)1ccbd13fix(typedoc): documentation & API completeness fixes (#4321)