Accept prestage/on-release path values in products.yml features.release-notes - #3854
Open
cotti wants to merge 4 commits into
Open
Accept prestage/on-release path values in products.yml features.release-notes#3854cotti wants to merge 4 commits into
cotti wants to merge 4 commits into
Conversation
GitHubPrService, GitHubReleaseService, and GitHubCommitRangeService each duplicated HttpClient setup, User-Agent/Accept headers, and GITHUB_TOKEN bearer attachment; the two older services used a static client that could not be faked at the HTTP level. The shared transport centralizes those concerns and gives every consumer an injectable HttpMessageHandler for fake-HTTP tests, while each service keeps its own response policy (lenient warn-and-null vs strict fail-the-run). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
An error occurred while trying to automatically change base from
feature/github-api-transport
to
main
August 13, 2026 12:04
cotti
force-pushed
the
feature/products-release-notes-path
branch
from
August 13, 2026 12:48
f9d00bd to
befd3a6
Compare
…se-notes The release-notes onboarding RFC (docs-eng-team#698, B3) registers each product's onboarding path in products.yml. The features map now accepts strings so release-notes can declare prestage or on-release; the historical booleans keep their meaning (omitted/true = on-release participation, false = opted out), so existing files parse unchanged. The Prestage Release Orchestrator and onboarding validation build on this flag. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cotti
force-pushed
the
feature/products-release-notes-path
branch
from
August 13, 2026 12:48
befd3a6 to
33bc407
Compare
Mpdreamz
approved these changes
Aug 13, 2026
… IAppDataFileSystem signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release-notes onboarding RFC (docs-eng-team#698, item B3) registers each product's onboarding path in
products.ymlso central automation — the Prestage Release Orchestrator, onboarding validation (next PR in this stack) — can resolve which repositories participate and how. Todayfeatures.release-notesonly parses as a boolean.What
features.release-notesnow acceptsprestageandon-releasealongside the historical booleans, resolving to aReleaseNotesPath(None/OnRelease/Prestage) on the product model. Backward compatible: omitted/truemean on-release participation (the previous default),falseopts out, so every existingproducts.ymlparses unchanged. The features map is now string-valued with explicit per-key validation, and invalid values get actionable errors. Catalog docs updated with the value table.Stack: 1/5 of the RFC B-items (B3 → B4 → B2 → B1 → B5), based on #3849.