Add changelog validate-onboarding for Prestage registration drift - #3855
Open
cotti wants to merge 4 commits into
Open
Add changelog validate-onboarding for Prestage registration drift#3855cotti wants to merge 4 commits into
cotti wants to merge 4 commits into
Conversation
cotti
force-pushed
the
feature/release-notes-onboarding-validation
branch
from
August 13, 2026 12:48
d26f390 to
025a4f7
Compare
A product registered as features.release-notes: prestage without the Prestage scaffolding in its repository would silently be skipped by the Prestage Release Orchestrator or fail at feature freeze. The new command probes each Prestage product's repository (contents API) for the changelog configuration and the validate/submit/upload/bundle-stage workflows, exiting non-zero on drift so CI can gate on it (RFC B4, docs-eng-team#698). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cotti
force-pushed
the
feature/release-notes-onboarding-validation
branch
from
August 13, 2026 12:48
025a4f7 to
7ab6b05
Compare
Mpdreamz
approved these changes
Aug 13, 2026
…-onboarding-validation
… IAppDataFileSystem signature
…ath' into feature/release-notes-onboarding-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A product registered as
features.release-notes: prestagewhose repository lacks the Prestage scaffolding would silently be skipped by the Prestage Release Orchestrator — or fail at feature freeze, the worst possible moment. Registration drift needs to be CI-gateable (RFC B4, docs-eng-team#698).What
New
docs-builder changelog validate-onboardingcommand: for every Prestage-registered product it probes the repository (resolved from the product key or itsrepository:override) via the GitHub contents API for the changelog configuration (docs/changelog.ymlor rootchangelog.yml) and thechangelog-validate/changelog-submit/changelog-upload/changelog-bundle-stageworkflows, emitting one actionable error per product with the missing files and exiting non-zero. Unreadable repositories (bad credentials, rate limiting) fail the run rather than passing it vacuously. Uses the sharedGitHubApiTransport, so the whole thing is covered by fake-HTTP tests.Stack: 2/5 — depends on the
features.release-notespath values (#3854).