You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
components/player/Queue.vue starts a 1-second setInterval on every mount, including station-list view, hidden queue and stations with no reference schedule. The callback guards state, but the interval itself still wakes the main thread. This is a narrow performance/timers audit fix related to #328.
Change
Derive clock eligibility from schedule tab, queue visibility, reference-guide mode and nonempty programme list.
Start the timer only while eligible; stop on deactivation and component teardown; refresh wall-clock immediately on reactivation.
Extend station-schedule.test.mjs source regression assertions to ensure clock activation/cleanup are wired.
Evidence / tests
Before: unconditional scheduleClockTimer = setInterval(..., 1000) in onMounted.
Source review completed. npm test, Nuxt build and browser QA not yet executed in this run; CI must confirm. This is not a claim of measured performance improvement.
Acceptance criteria
No 1-second queue timer when the station list is active, queue hidden, or reference programme absent.
Exactly one timer while a visible reference schedule is selected; clock resumes with current wall time after reactivation.
Unmount clears the interval; schedule auto-scroll and playback remain unchanged.
Risks
A delayed reactive state transition may briefly defer clock activation; watch is created after mount and immediately synchronized.
Manual browser verification of schedule transitions and mobile sidebar is still required.
No production deploy, release, branch protection or secrets changes.
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified source-level bug
components/player/Queue.vuestarts a 1-secondsetIntervalon every mount, including station-list view, hidden queue and stations with no reference schedule. The callback guards state, but the interval itself still wakes the main thread. This is a narrow performance/timers audit fix related to #328.Change
station-schedule.test.mjssource regression assertions to ensure clock activation/cleanup are wired.Evidence / tests
scheduleClockTimer = setInterval(..., 1000)inonMounted.watch(needsScheduleClock, ..., { immediate: true })insideonMounted, with explicitstopScheduleClock().npm test, Nuxt build and browser QA not yet executed in this run; CI must confirm. This is not a claim of measured performance improvement.Acceptance criteria
Risks
No production deploy, release, branch protection or secrets changes.