You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(player): tolerate blocked localStorage without breaking controls - #521
components/player/Player.vue directly calls localStorage.getItem/setItem for queue, mini/compact mode and audio preferences. When a browser blocks storage (SecurityError, privacy/sandbox policy, quota), these uncaught calls can abort player initialization or UI button handlers, although storage persistence is optional.
Fix
Add small guarded read/write helpers; denied reads return null (default UI), writes return false without throwing.
Use them for player queue, mini/compact controls and audio preferences only; no change to stored keys or values.
Add Node regression tests for round trip, denied access and independent read/write failures.
Evidence and testing
Source reproduction: unguarded calls in Player.vue before fix, including onMounted initialization and setQueueOpen/togglePlayerCompact/setPlayerMini.
Focused helper smoke tests executed locally with Node 22.16.0: 3/3 pass. The committed regression suite has the same scenarios with additional volume assertion.
Full repository npm test, Node 24.15.0 CI, Nuxt build and browser/iOS QA not yet run; do not treat local helper tests as end-to-end proof.
Acceptance
Player mounts with storage unavailable, using default UI settings.
Queue/mini/compact controls remain usable when writes fail.
Normal storage persistence and audio preferences unchanged.
No autoplay, playback lifecycle or SEO changes.
Risk / QA
Persistence cannot survive reload when the browser denies storage; this is expected.
Verify Safari private/restricted contexts and normal Chrome storage, then inspect CI and manual playback/volume.
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified bug (storage/privacy audit)
components/player/Player.vuedirectly callslocalStorage.getItem/setItemfor queue, mini/compact mode and audio preferences. When a browser blocks storage (SecurityError, privacy/sandbox policy, quota), these uncaught calls can abort player initialization or UI button handlers, although storage persistence is optional.Fix
Evidence and testing
npm test, Node 24.15.0 CI, Nuxt build and browser/iOS QA not yet run; do not treat local helper tests as end-to-end proof.Acceptance
Risk / QA
658fe00e80a6c13e65a2a533364102f01932fd70; does not include pending fix(player): avoid idle 1-second queue schedule timer #520. No merge/deploy/release.