Skip to content

Fix ICE in BuildDisposableCleanup when Dispose extension methods are in scope #19568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+28 −1
Open

Fix ICE in BuildDisposableCleanup when Dispose extension methods are in scope #19568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
581eb58
Initial plan
Copilot Apr 10, 2026
b2af65d
Fix ICE in BuildDisposableCleanup when Dispose extension methods are …
Copilot Apr 10, 2026
ae32c6f
Merge branch 'main' into copilot/fix-internal-error-disposable-cleanup
T-Gro Apr 20, 2026
c44e99a
Add release notes for PR #19568
T-Gro Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.FSharp.Compiler.Service/11.0.100.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
* Fix signature generation: backtick escaping for identifiers containing backticks. ([Issue #15389](https://github.com/dotnet/fsharp/issues/15389), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
* Fix signature generation: `private` keyword placement for prefix-style type abbreviations. ([Issue #15560](https://github.com/dotnet/fsharp/issues/15560), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
* Fix signature generation: missing `[<Class>]` attribute for types without visible constructors. ([Issue #16531](https://github.com/dotnet/fsharp/issues/16531), [PR #19586](https://github.com/dotnet/fsharp/pull/19586))
* Fix internal compiler error in `use` bindings when a C#-style `Dispose` extension method is in scope alongside `IDisposable.Dispose`. ([Issue #19552](https://github.com/dotnet/fsharp/issues/19552), [PR #19568](https://github.com/dotnet/fsharp/pull/19568))

### Added

Expand Down
2 changes: 1 addition & 1 deletion src/Compiler/Checking/Expressions/CheckExpressions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3154,7 +3154,7 @@ let BuildDisposableCleanup (cenv: cenv) env m (v: Val) =
v.SetHasBeenReferenced()

let disposeMethod =
match TryFindIntrinsicOrExtensionMethInfo ResultCollectionSettings.AllResults cenv env m ad "Dispose" g.system_IDisposable_ty with
match TryFindIntrinsicOrExtensionMethInfo ResultCollectionSettings.AtMostOneResult cenv env m ad "Dispose" g.system_IDisposable_ty with
| [x] -> x
| _ -> error(InternalError(FSComp.SR.tcCouldNotFindIDisposable(), m))

Expand Down
26 changes: 26 additions & 0 deletions ...Sharp.Compiler.ComponentTests/Conformance/BasicGrammarElements/UseBindings/UseBindings.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,29 @@ module UseBindings =
|> asFsx
|> compile
|> shouldSucceed

[<Fact>]
let ``use binding does not ICE when Dispose extension method is in scope`` () =
FSharp """
open System
open System.Runtime.CompilerServices

type Disposable() =
interface IDisposable with
member _.Dispose() = ()

[<Extension>]
type PublicExtensions =
[<Extension>]
static member inline Dispose(this: #IDisposable) =
this

let foo() =
use a = new Disposable()
()

foo()
"""
|> asExe
|> compile
|> shouldSucceed
Loading