Skip to content

style: extract jetbrains goconst literals to constants #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 18, 2026
Merged

style: extract jetbrains goconst literals to constants #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c527d43
style: extract jetbrains goconst literals to constants
devsy-app[bot] Aug 14, 2026
61f4289
Merge branch 'main' into lint-fixer/jetbrains-goconst
skevetter Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/clion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var CLionOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/dataspell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var DataSpellOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
7 changes: 6 additions & 1 deletion pkg/ide/jetbrains/generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ const (
VersionOption = "VERSION"
DownloadAmd64Option = "DOWNLOAD_AMD64"
DownloadArm64Option = "DOWNLOAD_ARM64"

versionOptionDescription = "The version for the binary"
versionOptionDefault = "latest"
downloadArm64OptionDescription = "The download url for the arm64 server binary"
downloadAmd64OptionDescription = "The download url for the amd64 server binary"
)

func getLatestDownloadURL(code string, platform string) string {
Expand All @@ -42,7 +47,7 @@ func getDownloadURLs(
) (string, string) {
version := options.GetValue(values, VersionOption)
var amd64Download, arm64Download string
if version == "latest" {
if version == versionOptionDefault {
amd64Download = getLatestDownloadURL(productCode, "linux")
arm64Download = getLatestDownloadURL(productCode, "linuxARM64")
} else {
Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/goland.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var GolandOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/intellij.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var IntellijOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/phpstorm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var PhpStormOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/pycharm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var PyCharmOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/rider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var RiderOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/rubymine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var RubyMineOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/rustrover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var RustRoverOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
8 changes: 4 additions & 4 deletions pkg/ide/jetbrains/webstorm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ const (
var WebStormOptions = ide.Options{
VersionOption: {
Name: VersionOption,
Description: "The version for the binary",
Default: "latest",
Description: versionOptionDescription,
Default: versionOptionDefault,
},
DownloadArm64Option: {
Name: DownloadArm64Option,
Description: "The download url for the arm64 server binary",
Description: downloadArm64OptionDescription,
},
DownloadAmd64Option: {
Name: DownloadAmd64Option,
Description: "The download url for the amd64 server binary",
Description: downloadAmd64OptionDescription,
},
}

Expand Down
Loading