You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Linter: golangci-lint → goconst category.
Fix method: mechanical (extract shared string literals into named constants).
Findings fixed
The JetBrains IDE package (pkg/ide/jetbrains/) had goconst findings for four
string literals repeated identically across all 10 IDE definition files
(goland, intellij, phpstorm, clion, dataspell, pycharm, rider, rubymine,
rustrover, webstorm), plus the version-default comparison in generic.go:
"The version for the binary" — 10 occurrences
"latest" (VersionOption default) — 11 occurrences
"The download url for the arm64 server binary" — 10 occurrences
"The download url for the amd64 server binary" — 10 occurrences
Change
Introduced four unexported constants in pkg/ide/jetbrains/generic.go and
referenced them everywhere the literals previously appeared:
versionOptionDescription="The version for the binary"versionOptionDefault="latest"downloadArm64OptionDescription="The download url for the arm64 server binary"downloadAmd64OptionDescription="The download url for the amd64 server binary"
No behavioral change — the option descriptions and default values are byte-for-byte
identical to before. 41 occurrences replaced across 11 files.
Verification
task cli:format — clean (gci/gofumpt/golines re-aligned the const block).
task cli:lint:ci — 0 issues (no new findings introduced by the patch).
task cli:lint (full) — confirmed the jetbrains goconst findings are cleared;
no goconst/lll findings remain in any pkg/ide/jetbrains/*.go file.
task cli:test — passes (the only failures are the pre-existing pkg/git TestRepoClone* stale-assertion failures on origin/main, unrelated to this
change; verified they fail identically on a clean checkout).
go build ./pkg/ide/jetbrains/ — builds cleanly.
This PR was created by an AI agent as part of an automated daily lint fix job.
## Summary
Linter: `golangci-lint` → `goconst` category.
Fix method: mechanical (extract shared string literals into named constants).
## Findings fixed
The JetBrains IDE package (`pkg/ide/jetbrains/`) had `goconst` findings for four
string literals repeated identically across all 10 IDE definition files
(goland, intellij, phpstorm, clion, dataspell, pycharm, rider, rubymine,
rustrover, webstorm), plus the version-default comparison in `generic.go`:
- `"The version for the binary"` — 10 occurrences
- `"latest"` (VersionOption default) — 11 occurrences
- `"The download url for the arm64 server binary"` — 10 occurrences
- `"The download url for the amd64 server binary"` — 10 occurrences
## Change
Introduced four unexported constants in `pkg/ide/jetbrains/generic.go` and
referenced them everywhere the literals previously appeared:
```go
versionOptionDescription = "The version for the binary"
versionOptionDefault = "latest"
downloadArm64OptionDescription = "The download url for the arm64 server binary"
downloadAmd64OptionDescription = "The download url for the amd64 server binary"
```
No behavioral change — the option descriptions and default values are byte-for-byte
identical to before. 41 occurrences replaced across 11 files.
## Verification
- `task cli:format` — clean (gci/gofumpt/golines re-aligned the const block).
- `task cli:lint:ci` — **0 issues** (no new findings introduced by the patch).
- `task cli:lint` (full) — confirmed the jetbrains `goconst` findings are cleared;
no `goconst`/`lll` findings remain in any `pkg/ide/jetbrains/*.go` file.
- `task cli:test` — passes (the only failures are the pre-existing `pkg/git`
`TestRepoClone*` stale-assertion failures on `origin/main`, unrelated to this
change; verified they fail identically on a clean checkout).
- `go build ./pkg/ide/jetbrains/` — builds cleanly.
This PR was created by an AI agent as part of an automated daily lint fix job.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linter:
golangci-lint→goconstcategory.Fix method: mechanical (extract shared string literals into named constants).
Findings fixed
The JetBrains IDE package (
pkg/ide/jetbrains/) hadgoconstfindings for fourstring literals repeated identically across all 10 IDE definition files
(goland, intellij, phpstorm, clion, dataspell, pycharm, rider, rubymine,
rustrover, webstorm), plus the version-default comparison in
generic.go:"The version for the binary"— 10 occurrences"latest"(VersionOption default) — 11 occurrences"The download url for the arm64 server binary"— 10 occurrences"The download url for the amd64 server binary"— 10 occurrencesChange
Introduced four unexported constants in
pkg/ide/jetbrains/generic.goandreferenced them everywhere the literals previously appeared:
No behavioral change — the option descriptions and default values are byte-for-byte
identical to before. 41 occurrences replaced across 11 files.
Verification
task cli:format— clean (gci/gofumpt/golines re-aligned the const block).task cli:lint:ci— 0 issues (no new findings introduced by the patch).task cli:lint(full) — confirmed the jetbrainsgoconstfindings are cleared;no
goconst/lllfindings remain in anypkg/ide/jetbrains/*.gofile.task cli:test— passes (the only failures are the pre-existingpkg/gitTestRepoClone*stale-assertion failures onorigin/main, unrelated to thischange; verified they fail identically on a clean checkout).
go build ./pkg/ide/jetbrains/— builds cleanly.This PR was created by an AI agent as part of an automated daily lint fix job.