Skip to content

#1587 - Fix: Remove temporary Go tools directory #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvatsal60 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#1587 - Fix: Remove temporary Go tools directory #1588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f76ce4
Fix: Remove temporary Go tools directory
gvatsal60 Feb 22, 2026
1680f39
Merge branch 'main' into fix/#1587_go
Kaniska244 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/go/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,11 @@ GO_TOOLS="\
if [ "${INSTALL_GO_TOOLS}" = "true" ]; then
echo "Installing common Go tools..."
export PATH=${TARGET_GOROOT}/bin:${PATH}
mkdir -p /tmp/gotools /usr/local/etc/vscode-dev-containers ${TARGET_GOPATH}/bin
cd /tmp/gotools
export GOPATH=/tmp/gotools
export GOCACHE=/tmp/gotools/cache
export GOCACHE=${GOPATH}/cache

mkdir -p ${GOPATH} /usr/local/etc/vscode-dev-containers ${TARGET_GOPATH}/bin
cd ${GOPATH}

# Use go get for versions of go under 1.16
go_install_command=install
Expand All @@ -316,10 +317,9 @@ if [ "${INSTALL_GO_TOOLS}" = "true" ]; then

(echo "${GO_TOOLS}" | xargs -n 1 go ${go_install_command} -v )2>&1 | tee -a /usr/local/etc/vscode-dev-containers/go.log

# Move Go tools into path and clean up
if [ -d /tmp/gotools/bin ]; then
mv /tmp/gotools/bin/* ${TARGET_GOPATH}/bin/
rm -rf /tmp/gotools
# Move Go tools into path
if [ -d "${GOPATH}/bin" ]; then
mv ${GOPATH}/bin/* ${TARGET_GOPATH}/bin/
fi

# Install golangci-lint from precompiled binares
Expand All @@ -332,6 +332,9 @@ if [ "${INSTALL_GO_TOOLS}" = "true" ]; then
curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | \
sh -s -- -b "${TARGET_GOPATH}/bin" "v${GOLANGCILINT_VERSION}"
fi

# Remove Go tools temp directory
rm -rf ${GOPATH}
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm -rf ${GOPATH} is unquoted and unguarded. Since this runs under set -e and is now unconditional, it’s safer to use rm -rf -- "${GOPATH}" and optionally add a defensive check (e.g., non-empty and expected /tmp/... prefix) to avoid accidental deletion if GOPATH is ever changed/overridden.

Suggested change
rm -rf ${GOPATH}
if [ -n "${GOPATH}" ] && [[ "${GOPATH}" == /tmp/gotools* ]]; then
rm -rf -- "${GOPATH}"
fi

Copilot uses AI. Check for mistakes.
fi


Expand Down