#1587 - Fix: Remove temporary Go tools directory

[gvatsal60]

Issue: #1587

This pull request refactors the Go tools installation process in src/go/install.sh to improve directory handling and cleanup. The changes mainly focus on using a consistent temporary directory for Go tools, updating environment variables, and ensuring proper cleanup after installation.

Improvements to directory management and environment variables:

• Changed the creation and usage of the temporary Go tools directory to use the GOPATH variable consistently, updated the GOCACHE assignment, and ensured all related directories are created before use.
• Updated the logic for moving installed Go tools to use the ${GOPATH}/bin path instead of a hardcoded /tmp/gotools/bin path.

Cleanup enhancements:

• Added a step to remove the temporary Go tools directory (${GOPATH}) after installation is complete, ensuring no leftover files remain.

[Copilot]

Pull request overview

Refactors the Go feature’s tool-install flow to ensure the temporary GOPATH directory used for building Go tools is handled consistently and fully cleaned up, addressing reported leftover cache/module artifacts in built images.

Changes:

• Switches GOCACHE to be derived from GOPATH (${GOPATH}/cache) and uses ${GOPATH} consistently for temp directory operations.
• Moves installed tool binaries from ${GOPATH}/bin into ${TARGET_GOPATH}/bin.
• Adds an unconditional cleanup step to remove the temporary Go tools directory after tool and golangci-lint installation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

rm -rf ${GOPATH} is unquoted and unguarded. Since this runs under set -e and is now unconditional, it’s safer to use rm -rf -- "${GOPATH}" and optionally add a defensive check (e.g., non-empty and expected /tmp/... prefix) to avoid accidental deletion if GOPATH is ever changed/overridden.

Suggested change

	rm -rf ${GOPATH}
	if [ -n "${GOPATH}" ] && [[ "${GOPATH}" == /tmp/gotools* ]]; then
	rm -rf -- "${GOPATH}"
	fi

[Kaniska244]

Hi @gvatsal60

Thank you for the contribution. Would you please bump the go feature version and is there any problem you foresee with implementing this suggestion?