You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: end each search result with its own dot - #1455
Search results, including hashtag searches such as /search?q=%23laravel, ran one continuous graph line through every result, as if they were a single thread. The results are unrelated commits, so each one now ends in its own dot, the same way the home feed draws its commits. This applies to both the Most relevant and Latest tabs.
This PR is stacked on #1454 and includes its commit. Merge #1454 first, and this diff then shrinks to the second commit.
Changes
The test that expected the search results to end on a single dot now expects one dot per result.
SearchResults now always draws each CommitCard with endsWithDot and no previousLane or graphAfter, the way commit-feed.tsx draws its cards.
fix: end each hot topic commit with its own dot #1454 added an isStandalone prop for this behavior. With search drawing results this way too, all three callers (the hot topic page and both search tabs) would set it, so this PR removes the prop, the connected branch and the authorLaneColor import that only that branch used.
BEFORE
AFTER
Summary by CodeRabbit
Updates
Commit search results now show a consistent end marker on every commit card, rather than only on the final card. Lane and graph connector details are no longer displayed in search results, providing a simplified, consistent presentation across the list.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 0fd70a67-0329-4c08-92fe-8a5d04d2cfff
Commits
Reviewing files that changed from the base of the PR and between 1ed631c and 79a9061.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
Search result cards no longer receive previousLane or graphAfter. Each card now has endsWithDot set to true. The unused authorLaneColor import is removed.
Changes: Search result rendering
Layer / File(s)
Summary
Update search result card props resources/js/components/commit-search-results.tsx, tests/Unit/StandaloneCommitGraphs.test.tsx
The result mapping no longer reads the previous commit or passes previousLane and graphAfter to CommitCard. It sets endsWithDot to true for every card. The test expects three rail-end dots for three results.
dev-null-sh/dev-null.sh#1226: Adds the search graph behavior that this change updates to use one dot per result.
Suggested reviewers:paulinevos
Merge Risk: Minimal · previous review aa865
No actionable merge-blocking risk is evidenced; the search-result rendering change is ready for normal checks.
Architecture risk: Low · up to aa865
The change affects 2 systems.
Changed systems:resources, tests
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — resources (ui) was modified; 1 changed file maps to changed impact.
observed — tests (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in resources/js/components/commit-search-results.tsx: Removed the authorLaneColor import.
observed — Modified behavior in resources/js/components/commit-search-results.tsx: The result mapping no longer reads the previous commit or passes previousLane and graphAfter to each CommitCard. It now sets endsWithDot to true for every card; previously this was true only for the last card.
observed — Modified behavior in tests/Unit/StandaloneCommitGraphs.test.tsx: The test title now describes each search result ending on its own dot rather than a single chain-ending dot.
observed — Modified behavior in tests/Unit/StandaloneCommitGraphs.test.tsx: The test now expects three rail-end dots instead of one and removes the assertion that the dot appears after “Commit two.”
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: each search result now ends with its own graph dot.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 05e4b7fe-dd97-43af-88e0-c8ea3762ad02
Commits
Reviewing files that changed from the base of the PR and between 0a1826f and aa865f4.
Files selected for processing: 1
tests/Unit/StandaloneCommitGraphs.test.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search results, including hashtag searches such as
/search?q=%23laravel, ran one continuous graph line through every result, as if they were a single thread. The results are unrelated commits, so each one now ends in its own dot, the same way the home feed draws its commits. This applies to both the Most relevant and Latest tabs.This PR is stacked on #1454 and includes its commit. Merge #1454 first, and this diff then shrinks to the second commit.
Changes
SearchResultsnow always draws eachCommitCardwithendsWithDotand nopreviousLaneorgraphAfter, the waycommit-feed.tsxdraws its cards.isStandaloneprop for this behavior. With search drawing results this way too, all three callers (the hot topic page and both search tabs) would set it, so this PR removes the prop, the connected branch and theauthorLaneColorimport that only that branch used.BEFORE
AFTER
Summary by CodeRabbit