Skip to content

fix: end each related commit with its own dot - #1459

Open
richardkeep wants to merge 2 commits into
dev-null-sh:productionfrom
richardkeep:fix/related-commits-graph-dots
Open

richardkeep wants to merge 2 commits into
dev-null-sh:productionfrom
richardkeep:fix/related-commits-graph-dots

Conversation

@richardkeep

@richardkeep richardkeep commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The "Related commits" section under a commit ran one continuous graph line through every related commit, as if they were a thread. They relate to the commit shown, not to each other, so each one now ends in its own dot, the same way the home feed draws its commits. #1454 does the same for hot topics and #1455 for search results.

Changes

  • RelatedCommitList draws each CommitCard with endsWithDot and no previousLane or graphAfter, the way commit-feed.tsx draws its cards. The laneOf import, which only the chaining used, is removed.
  • tests/Unit/StandaloneCommitGraphs.test.tsx now expects one end dot per related commit instead of a single dot below the last one.

BEFORE

image

AFTER

image

Summary by CodeRabbit

  • User Experience
    • Related commits now appear as independent cards, each ending with its own rail dot, rather than being connected in a chain.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Related commit cards no longer form a linked chain. Each card now ends with a dot, and the related-commit test checks for one dot per commit.

Changes: Related commit rendering

Layer / File(s) Summary
Render and verify independent commit cards
resources/js/components/related-commits.tsx, tests/Unit/StandaloneCommitGraphs.test.tsx
The related-commit list renders each card with an ending dot and no longer passes the preceding commit’s lane or ID. The test expects three dots for three commits.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: jubianchi

Merge Risk: Minimal · up to c209b

Related commits now render as independent cards with their own endpoints, and the updated regression test runs in CI. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix: end each related commit with its own dot" matches the changeset. The raw summary says RelatedCommitList no longer chains related commits through lane and ID, and each card now ends wit…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix: end each related commit with its own dot" matches the changeset. The raw summary says RelatedCommitList no longer chains related commits through lane and ID, and each card now ends with its own dot. The test was updated to expect one end dot per commit. The title is concise, specific, and states the primary change from the developer's perspective.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c7201867-5574-4197-86c0-add075919a32
Commits

Reviewing files that changed from the base of the PR and between f2423d6 and c209b2b.

Files selected for processing: 2
  • resources/js/components/related-commits.tsx
  • tests/Unit/StandaloneCommitGraphs.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

@richardkeep
richardkeep marked this pull request as ready for review November 4, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant