Skip to content

MENDELU/Replace footer "Theme by" with a copyright sign #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatusBeke wants to merge 2 commits into from
Closed

MENDELU/Replace footer "Theme by" with a copyright sign #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ce02d
MENDELU/Replace footer "Theme by" with a copyright sign
MatusBeke Aug 17, 2026
bd7e6c4
MENDELU/Don't render the vendor credit when no company is configured
MatusBeke Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/assets/i18n/cs.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10980,8 +10980,5 @@
// "contact-us.email": "Email: ",
"contact-us.email": "Email: ",

// "footer.theme.by.message": "Theme by",
"footer.theme.by.message": "Theme by",


}
2 changes: 0 additions & 2 deletions src/assets/i18n/en.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7281,6 +7281,4 @@
"contact-us.feedback": "Feedback",

"contact-us.email": "Email: ",

"footer.theme.by.message": "Theme by",
}
13 changes: 5 additions & 8 deletions src/themes/custom/app/footer/footer.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,11 @@ <h5 class="text-uppercase">Footer Content</h5>

<!-- Right Column - Theme Sign -->
<div class="col-12 col-md-2 text-center">
<div class="footer-sign">
<p class="theme-by mb-1">{{ 'footer.theme.by.message' | translate }}</p>
<a class="dtq-sign text-white" *ngVar="(themedByCompanyName$ | async)?.payload?.values[0] as companyName"
[href]="(themedByUrl$ | async)?.payload?.values[0]"
[title]="companyName">
{{ companyName }}
</a>
</div>
@if ((themedByCompanyName$ | async)?.payload?.values?.[0]; as companyName) {
<p class="footer-sign"><a class="dtq-sign"
[href]="(themedByUrl$ | async)?.payload?.values?.[0]"
rel="noopener">{{ companyName }}</a><span class="footer-sign__mark">&#169;</span></p>
}
</div>
</div>
</div>
Expand Down
40 changes: 40 additions & 0 deletions src/themes/custom/app/footer/footer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,46 @@
.btn {
box-shadow: none;
}

// Vendor credit at the right end of the bar. White to match the nav links
// beside it — note that #fff on this green measures 2.29:1 and is below the
// WCAG AA threshold, same as those links already are. Kept on a single
// non-breaking line so the © can never strand itself above the name.
.footer-sign {
font-size: 1.0625rem;
font-weight: 500;
line-height: 1.2;
letter-spacing: 0.012em;
white-space: nowrap;
color: #fff;

// The © is set as a superscript of the company name, the way a trademark
// mark rides a wordmark. line-height: 0 keeps it from adding to the line box.
&__mark {
font-size: 0.68em;
font-weight: 400;
vertical-align: super;
line-height: 0;
margin-left: 0.12em;
}

.dtq-sign {
color: inherit;
text-decoration: none;

&:hover,
&:focus-visible {
text-decoration: underline;
text-underline-offset: 0.18em;
}

&:focus-visible {
outline: 2px solid #fff;
outline-offset: 3px;
border-radius: 2px;
}
}
}
}

.footer-logo {
Expand Down
2 changes: 0 additions & 2 deletions src/themes/custom/app/footer/footer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { RouterLink } from '@angular/router';
import { TranslateModule } from '@ngx-translate/core';

import { FooterComponent as BaseComponent } from '../../../../app/footer/footer.component';
import { VarDirective } from '../../../../app/shared/utils/var.directive';

@Component({
selector: 'ds-themed-footer',
Expand All @@ -17,7 +16,6 @@ import { VarDirective } from '../../../../app/shared/utils/var.directive';
AsyncPipe,
RouterLink,
TranslateModule,
VarDirective,
],
})
export class FooterComponent extends BaseComponent {
Expand Down
Loading