MENDELU/Replace footer "Theme by" with a copyright sign - #1457
Closed
MatusBeke wants to merge 2 commits into
Closed
Conversation
The vendor credit in the footer read "Theme by / + dataquest", with the words stacked above the company name. Replace the wording with a bare copyright sign set as a superscript of the name, so the credit reads "+ dataquest©" on a single line. The old wording came from the i18n key footer.theme.by.message, which is now unused and removed from en.json5 and cs.json5 — a copyright sign is a symbol, not a translated word, so English and Czech render identically. Layout notes: - The stacking came from a block-level <p> inside a d-flex wrapper in a narrow col-md-2 cell. Both are gone; the credit is now one line of text with white-space: nowrap, so the sign can never strand itself. - line-height: 0 on the superscript keeps it out of the line box, so the footer stays 83px tall, exactly as before. - The redundant [title] tooltip is dropped; the link text already supplies the accessible name. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke
added a commit
that referenced
this pull request
Aug 17, 2026
Collaborator
Author
The footer a11y e2e test failed with a link-name violation: when the backend does not expose themed.by.company.name — which is the case on the CI stack — the anchor rendered as <a href=""></a>, an empty link with no discernible text. Guard the whole credit with @if on the company name, the same way the base footer component does, so nothing renders at all when there is no vendor configured. This also stops a lone © from appearing without a name. *ngVar is no longer needed, so VarDirective drops out of the component's imports — it had no other use in this template. Refs dataquest-dev/dspace-customers#592 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke
requested review from
milanmajchrak
and
a balanced review from Copilot
August 17, 2026 13:02
There was a problem hiding this comment.
Pull request overview
Updates the MENDELU footer vendor credit to display + dataquest© on one line with a superscript copyright mark.
Changes:
- Reworks the vendor-credit markup and styling.
- Removes the obsolete translation key and
VarDirective. - Preserves the configured company name and link.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
footer.component.ts |
Removes the unused directive. |
footer.component.scss |
Adds vendor-credit and superscript styling. |
footer.component.html |
Updates the credit markup. |
en.json5 |
Removes the unused English translation. |
cs.json5 |
Removes the unused Czech translation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
milanmajchrak
approved these changes
Aug 17, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replaces the
Theme bywording in the footer's vendor credit with a bare copyright sign, set as a superscript of the company name.Part of dataquest-dev/dspace-customers#592. MENDELU first — once this is approved the same change goes out to the remaining seven customers.
Before / after
Theme byon its own line,+ dataqueststacked underneath+ dataquest©on a single line, sign riding the name as a superscriptScreenshot below.
What changed
footer.component.html— the credit was a block-level<p>plus an<a>inside ad-flexwrapper, sitting in a narrowcol-md-2cell. That is what forced the two halves onto separate lines. It is now one line of text:footer.component.scss— new.footer-signblock..footer-sign,.theme-byand.dtq-signhad no rules of their own before; the layout came entirely from Bootstrap utilities, which cannot express a superscript or a non-breaking pair.en.json5/cs.json5—footer.theme.by.messageremoved. It is now unused: a copyright sign is a symbol, not a translated word, so English and Czech render identically. Both files still parse (3698 / 3695 keys).Verification
Run locally against the live dev-6 backend (real MENDELU theme and data), checked in both languages on the compiled build:
+ dataquest©(EN and CS identical)#fffvertical-align: super,line-height: 0https://www.dataquest.sk/dspaceline-height: 0on the superscript is deliberate: without it the raised glyph grows the line box and the whole bar gets taller.Notes for the reviewer
+in+ dataquestcomes from the backend propertythemed.by.company.nameand is untouched.#fffon this green measures 2.29:1, below the WCAG AA threshold of 4.5:1 — but the five nav links next to it already have exactly the same problem, so this PR neither introduces nor fixes it. Flagging it as a separate ticket rather than smuggling a visual change in here.[title]tooltip is dropped — the link text already supplies the accessible name.🤖 Generated with Claude Code