Skip to content

MENDELU/Replace footer "Theme by" with a copyright sign - #1457

Closed
MatusBeke wants to merge 2 commits into
customer/mendelufrom
mendelu/fe-footer-copyright
Closed

MENDELU/Replace footer "Theme by" with a copyright sign#1457
MatusBeke wants to merge 2 commits into
customer/mendelufrom
mendelu/fe-footer-copyright

Conversation

@MatusBeke

Copy link
Copy Markdown
Collaborator

Replaces the Theme by wording in the footer's vendor credit with a bare copyright sign, set as a superscript of the company name.

Part of dataquest-dev/dspace-customers#592. MENDELU first — once this is approved the same change goes out to the remaining seven customers.

Before / after

before Theme by on its own line, + dataquest stacked underneath
after + dataquest© on a single line, sign riding the name as a superscript

Screenshot below.

What changed

footer.component.html — the credit was a block-level <p> plus an <a> inside a d-flex wrapper, sitting in a narrow col-md-2 cell. That is what forced the two halves onto separate lines. It is now one line of text:

<p class="footer-sign"><a class="dtq-sign" >{{ companyName }}</a><span class="footer-sign__mark">&#169;</span></p>

footer.component.scss — new .footer-sign block. .footer-sign, .theme-by and .dtq-sign had no rules of their own before; the layout came entirely from Bootstrap utilities, which cannot express a superscript or a non-breaking pair.

en.json5 / cs.json5footer.theme.by.message removed. It is now unused: a copyright sign is a symbol, not a translated word, so English and Czech render identically. Both files still parse (3698 / 3695 keys).

Verification

Run locally against the live dev-6 backend (real MENDELU theme and data), checked in both languages on the compiled build:

rendered text + dataquest© (EN and CS identical)
name 17px, weight 500, #fff
sign 11.56px, vertical-align: super, line-height: 0
link target https://www.dataquest.sk/dspace
footer height 83px — unchanged

line-height: 0 on the superscript is deliberate: without it the raised glyph grows the line box and the whole bar gets taller.

Notes for the reviewer

  • The leading + in + dataquest comes from the backend property themed.by.company.name and is untouched.
  • The credit stays white to match the nav links beside it. Worth knowing: #fff on this green measures 2.29:1, below the WCAG AA threshold of 4.5:1 — but the five nav links next to it already have exactly the same problem, so this PR neither introduces nor fixes it. Flagging it as a separate ticket rather than smuggling a visual change in here.
  • The redundant [title] tooltip is dropped — the link text already supplies the accessible name.
  • Merging this triggers the deploy of instance 8573 on dev-6. Per the issue, JM and PU need to agree to the change first.

🤖 Generated with Claude Code

The vendor credit in the footer read "Theme by / + dataquest", with the
words stacked above the company name. Replace the wording with a bare
copyright sign set as a superscript of the name, so the credit reads
"+ dataquest©" on a single line.

The old wording came from the i18n key footer.theme.by.message, which is
now unused and removed from en.json5 and cs.json5 — a copyright sign is a
symbol, not a translated word, so English and Czech render identically.

Layout notes:
- The stacking came from a block-level <p> inside a d-flex wrapper in a
  narrow col-md-2 cell. Both are gone; the credit is now one line of text
  with white-space: nowrap, so the sign can never strand itself.
- line-height: 0 on the superscript keeps it out of the line box, so the
  footer stays 83px tall, exactly as before.
- The redundant [title] tooltip is dropped; the link text already supplies
  the accessible name.

Refs dataquest-dev/dspace-customers#592

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MatusBeke added a commit that referenced this pull request Aug 17, 2026
@MatusBeke

Copy link
Copy Markdown
Collaborator Author

Footer as it renders with this branch — MENDELU theme, run against the live dev-6 backend:

MENDELU footer with the copyright sign

The credit now reads + dataquest© on one line, sign riding the name as a superscript. Czech renders identically — only the nav links beside it change language.

The footer a11y e2e test failed with a link-name violation: when the
backend does not expose themed.by.company.name — which is the case on the
CI stack — the anchor rendered as <a href=""></a>, an empty link with no
discernible text.

Guard the whole credit with @if on the company name, the same way the base
footer component does, so nothing renders at all when there is no vendor
configured. This also stops a lone © from appearing without a name.

*ngVar is no longer needed, so VarDirective drops out of the component's
imports — it had no other use in this template.

Refs dataquest-dev/dspace-customers#592

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@MatusBeke
MatusBeke requested review from milanmajchrak and a balanced review from Copilot August 17, 2026 13:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MENDELU footer vendor credit to display + dataquest© on one line with a superscript copyright mark.

Changes:

  • Reworks the vendor-credit markup and styling.
  • Removes the obsolete translation key and VarDirective.
  • Preserves the configured company name and link.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
footer.component.ts Removes the unused directive.
footer.component.scss Adds vendor-credit and superscript styling.
footer.component.html Updates the credit markup.
en.json5 Removes the unused English translation.
cs.json5 Removes the unused Czech translation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MatusBeke

Copy link
Copy Markdown
Collaborator Author

Superseded by #1464. The team voted on the wording and picked the plain company name over a copyright sign, so this branch is being closed rather than reworked — #1464 starts fresh off customer/mendelu with no copyright markup in its history.

@MatusBeke MatusBeke closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants