Skip to content

style: rm warning for python 3.14 #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sicoyle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style: rm warning for python 3.14 #1072

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d07167
style: rm warning for python 3.14
sicoyle Jun 1, 2026
effb63e
Potential fix for pull request finding
sicoyle Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ext/dapr-ext-workflow/dapr/ext/workflow/_durabletask/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,11 @@ def __enter__(self):
return self

def __exit__(self, exc_type, exc, tb):
try:
self.close()
finally:
return False
# close() is best-effort and swallows its own errors, so a plain call is safe here.
# Returning False (i.e., not suppressing the original exception) is the same behavior
# as the previous try/finally, without the `return in finally` SyntaxWarning on Python 3.14+.
self.close()
return False

def close(self) -> None:
"""Close the underlying gRPC channel."""
Expand Down
Loading