Skip to content

style: rm warning for python 3.14#1072

Open
sicoyle wants to merge 2 commits into
dapr:mainfrom
sicoyle:style/rm-warning
Open

style: rm warning for python 3.14#1072
sicoyle wants to merge 2 commits into
dapr:mainfrom
sicoyle:style/rm-warning

Conversation

@sicoyle
Copy link
Copy Markdown
Contributor

@sicoyle sicoyle commented Jun 1, 2026

Description

This change will rm a warning we would get on python 3.14. Stylistic change for better UX.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Samantha Coyle <sam@diagrid.io>
Copilot AI review requested due to automatic review settings June 1, 2026 14:02
@sicoyle sicoyle requested review from a team as code owners June 1, 2026 14:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a Python 3.14+ SyntaxWarning triggered by a return inside a finally block in the workflow durable task gRPC client context manager, improving user experience while keeping the same exception-suppression behavior for workflow execution.

Changes:

  • Refactors TaskHubGrpcClient.__exit__ to avoid return in finally (Python 3.14+ warning).
  • Adds explanatory comments describing why returning False is preserved and why close() is safe to call directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ext/dapr-ext-workflow/dapr/ext/workflow/_durabletask/client.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.73%. Comparing base (bffb749) to head (effb63e).
⚠️ Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
...-workflow/dapr/ext/workflow/_durabletask/client.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   86.63%   82.73%   -3.90%     
==========================================
  Files          84      146      +62     
  Lines        4473    14692   +10219     
==========================================
+ Hits         3875    12155    +8280     
- Misses        598     2537    +1939     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sam <sam@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants