style: rm warning for python 3.14#1072
Open
sicoyle wants to merge 2 commits into
Open
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a Python 3.14+ SyntaxWarning triggered by a return inside a finally block in the workflow durable task gRPC client context manager, improving user experience while keeping the same exception-suppression behavior for workflow execution.
Changes:
- Refactors
TaskHubGrpcClient.__exit__to avoidreturninfinally(Python 3.14+ warning). - Adds explanatory comments describing why returning
Falseis preserved and whyclose()is safe to call directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 86.63% 82.73% -3.90%
==========================================
Files 84 146 +62
Lines 4473 14692 +10219
==========================================
+ Hits 3875 12155 +8280
- Misses 598 2537 +1939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sam <sam@diagrid.io>
seherv
approved these changes
Jun 1, 2026
seherv
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change will rm a warning we would get on python 3.14. Stylistic change for better UX.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: