Repository navigation
feat(ui): make Navigation's speed bigger and lift it off the bottom - #230
Merged
Merged
Conversation
261 px against 208, and 96 px higher. The largest numeral on the device.
Two changes, and the second is what paid for the first.
The number and its unit are centred in the band under the arrow's ring
rather than pushed down onto the bottom margin. Sitting them low was what
the first layout asked for; the ring is what decides how high they can go
now, and the group is centred in what it leaves.
Raising the number put the space below it back, so the unit moves there -
as Speed Only's does, and for the reason Speed Only gives: "beside would
mean reserving width that the three-digit case needs, which is exactly the
compromise that costs the face its size". Beside, the face was capped at
208 px by having to share 540 px with "MPH" and a gap. Underneath, the unit
costs no width at all, and the cap becomes how wide three cells can be.
That cap is 248 px at 30 px margins, which is Speed Only's ceiling. At this
height the number is the only thing across the panel and has nothing to
clear, so it takes a 16 px margin instead: three cells reach 564 px of 568,
and the face reaches 261 px. Measured, not guessed - the inline unit widths
that set the old cap were measured too ("MPH" is 70 px at montserrat_28,
49 px at montserrat_20), and inline could not have passed 234 px however
the unit was shrunk.
Resulting geometry: cell 188 x 317, ink 178..360 against 274..420, unit
368..398, three digits x 18..582. The digit cell hangs above its own ink,
which is harmless - the box is transparent and the glyphs start at 178 -
but it is asserted to stay on the panel.
Verified: make check, make firmware-container-build, all 78 simulator tests.
The rendered snapshot still cannot show the numeral at size, because the
host countdown_font is a stub that answers every size with one 52 px face;
the geometry above was checked against the arithmetic the device uses.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #229. 261 px against 208, and 96 px higher — the largest numeral on the device.
Two changes, and the second paid for the first.
Lifting it
The number and its unit are centred in the band under the arrow's ring rather than pushed onto the bottom margin. The ring is what decides how high they can go, and the group is centred in what it leaves.
Which paid for making it bigger
Raising the number put the space below it back, so the unit moves there — as Speed Only's does, and for the reason Speed Only gives:
Beside, the face was capped at 208 px by sharing 540 px with
MPHand a gap. Underneath, the unit costs no width at all, and the cap becomes how wide three cells can be.That cap is 248 px at 30 px margins — Speed Only's ceiling. At this height the number is the only thing across the panel and has nothing to clear, so it takes a 16 px margin instead: three cells reach 564 px of 568, and the face reaches 261 px.
Measured, not guessed. The inline widths that set the old cap were measured too —
MPHis 70 px at montserrat_28 and 49 px at montserrat_20 — and inline could not have passed 234 px however the unit was shrunk.Resulting geometry
The digit cell hangs above its own ink (cell top 108, glyphs from 178). Harmless — the box is transparent — but asserted to stay on the panel.
Verification
make check,make firmware-container-build, all 78 simulator tests.The rendered snapshot still cannot show the numeral at size: the host
countdown_fontis a stub that answers every size with one 52 px face, so the dashes draw at the cell top rather than where the real face puts them. The geometry above was checked against the arithmetic the device actually uses.Not yet flashed.
🤖 Generated with Claude Code