Skip to content

Update Hub managed terms: add usage stats clause and revise reference marketing#155

Open
SailReal wants to merge 2 commits intodevelopfrom
feature/add-usage-and-customer-reference
Open

Update Hub managed terms: add usage stats clause and revise reference marketing#155
SailReal wants to merge 2 commits intodevelopfrom
feature/add-usage-and-customer-reference

Conversation

@SailReal
Copy link
Copy Markdown
Member

No description provided.

@SailReal SailReal requested a review from tobihagemann April 23, 2026 21:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@SailReal has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 35 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 35 minutes and 35 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7411ade4-4700-474c-86a8-17bf59aeab38

📥 Commits

Reviewing files that changed from the base of the PR and between df89554 and 6aff175.

📒 Files selected for processing (2)
  • content/hub-managed-terms.de.md
  • content/hub-managed-terms.en.md

Walkthrough

The pull request updates two managed terms documents (German and English versions) with an effective date change to April 2026. A new §3.11 section was added authorizing the Provider to collect, process, and store aggregated, non-personal statistical and technical usage data for operational purposes, explicitly stating no personal data is involved. Additionally, §8 regarding reference marketing was modified to grant customer consent upon contract conclusion rather than as optional consent, and revocation mechanics were adjusted to require good cause unless the Provider's legitimate interest prevails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • tobihagemann
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, making it impossible to assess whether a description relates to the changeset. Add a pull request description explaining the purpose of the changes, the rationale for the new usage statistics clause and reference marketing modifications, and any relevant context for reviewers.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: adding a usage statistics clause (§3.11) and revising reference marketing consent mechanics (§8), which are the primary modifications across both German and English terms documents.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/add-usage-and-customer-reference

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@content/hub-managed-terms.de.md`:
- Around line 112-114: Sections 8.1 and 8.2 conflict: 8.1 treats reference use
as based on "ausdrückliche Zustimmung" while 8.2 limits withdrawal to "wichtiger
Grund" and allows provider's overriding "berechtigtes Interesse"; choose one
lawful basis and make both clauses consistent—either (A) keep consent: change
8.2 to state the customer may withdraw the consent at any time by emailing
hub-support@cryptomator.org and that withdrawal applies prospectively without
requiring a "wichtiger Grund" or provider override, or (B) switch 8.1 to rely on
"berechtigtes Interesse" and reword 8.1 to explicitly cite the legitimate
interest and change 8.2 to reflect a limited right to object according to GDPR
rules (including the provider's ability to override if their legitimate interest
prevails); update the wording in both 8.1 and 8.2 to reflect the chosen approach
and remove the inconsistent phrases ("ausdrückliche Zustimmung" vs. "wichtiger
Grund"/"überwiegt").
- Line 47: Der Text in §3.11 widerspricht §3.10: §3.11 verbietet jede Weitergabe
an Dritte, während §3.10 die Nutzung von Subunternehmern erlaubt; passe §3.11 so
an, dass er ausdrücklich erlaubt, dass aggregierte, nicht-personenbezogene
Nutzungs- und Telemetriedaten von Subunternehmern im Sinne von §3.10 verarbeitet
werden dürfen (z. B. durch Ergänzung wie "sofern dies gemäß §3.10 durch
vertraglich verpflichtete Subunternehmer erfolgt, die denselben
Vertraulichkeits- und Datenschutzpflichten unterliegen"), oder füge eine
Ausnahmeklausel hinzu, die klarstellt, welche Drittempfänger (z. B.
Subunternehmer, Hosting-/Analyse-Dienstleister) zulässig sind und dass
personenbezogene Daten weiterhin ausgeschlossen bleiben; referenziere dabei die
Vertragsstellen §3.10 und §3.11 beim Textänderungsentwurf.

In `@content/hub-managed-terms.en.md`:
- Around line 116-118: Sections "8.1" and "8.2" are inconsistent because 8.1
frames use of the Customer as a reference on "express consent" while 8.2
restricts revocation to "good cause" and defers to the Provider's legitimate
interest; choose one legal basis and make both clauses consistent: either (A)
keep "express consent" in 8.1 and remove the "for good cause" and "unless the
Provider's legitimate interest prevails" language from 8.2 so revocation by
email to hub-support@cryptomator.org is unconditional and prospective, or (B)
change 8.1 to state the Provider relies on a "legitimate interest" (not consent)
and adjust 8.2 to reflect that revocation is only effective if the Customer
demonstrates overriding interests (keeping the "unless the Provider's legitimate
interest prevails" wording); update the text of 8.1 and 8.2 accordingly so they
consistently reference the chosen legal basis.
- Line 50: §3.11 currently forbids disclosure of telemetry to third parties but
§3.10 allows subcontractors, creating a contractual inconsistency; update §3.11
to state that telemetry is only shared with third-party subprocessors engaged
under §3.10 and bound by equivalent confidentiality and data-processing
obligations, explicitly limit such sharing to aggregated, non-personal metrics
(no identifiers, emails, IPs, vault names), and require the Provider to ensure
subcontractors cannot re-identify data and are subject to the same security, use
restrictions and audit/contractual controls referenced in §3.10.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca15a149-420d-4b86-b312-f8ec2ed2c91b

📥 Commits

Reviewing files that changed from the base of the PR and between e25a748 and df89554.

📒 Files selected for processing (2)
  • content/hub-managed-terms.de.md
  • content/hub-managed-terms.en.md

Comment thread content/hub-managed-terms.de.md Outdated
Comment thread content/hub-managed-terms.de.md Outdated
Comment thread content/hub-managed-terms.en.md Outdated
Comment thread content/hub-managed-terms.en.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants