Skip to content

fix(nix): run dockerd from / so crashes can't leave core files in the checkout #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcogilvie wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(nix): run dockerd from / so crashes can't leave core files in the checkout #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nix.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ if [ "${NIX_SH_CONTAINER:-}" = "1" ]; then

# Start the Docker daemon, storing its data in the crossplane-cli-nix volume
# for persistence across container runs. This gives us a consistent Docker
# environment with cached images (e.g., kind node images).
dockerd --data-root=/nix/docker >/tmp/dockerd.log 2>&1 &
# environment with cached images (e.g., kind node images). Run it from / so
# its children don't use the bind-mounted checkout as their working
# directory; a crashing child would otherwise leave a core file there.
(cd / && exec dockerd --data-root=/nix/docker >/tmp/dockerd.log 2>&1) &

attempts=0
until docker info >/dev/null 2>&1; do
Expand Down
Loading