Repository navigation
Conversation
… checkout nix.sh started dockerd from the bind-mounted checkout, so dockerd and its children used it as their working directory. If one of them dumps core and the kernel's core_pattern is relative, the dump lands in the user's repo. On macOS with Rancher Desktop (Rosetta), BuildKit's emulator probe crashes at every dockerd start, leaving an empty `core` file in the repo root. Start dockerd from / instead. Its paths are all absolute, and nix still runs from the checkout. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
The title accurately describes the change, but it is 78 characters and exceeds the 72-character limit. | Shorten the title to 72 characters or fewer while preserving the main change, such as "fix(nix): run dockerd from / to avoid checkout core files". |
-
Check name Status Explanation Description check The description clearly explains why dockerdstarts from/, the affected environment, verification performed, and checklist status.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Breaking Changes The pull request changes only nix.sh. It does not modify files underapis/**orcmd/**, so it does not remove, rename, or require changes to public fields or flags.Feature Gate Requirement PASS. The pull request changes only nix.sh. It changesdockerdstartup to run from/and keeps the existing absolute data and log paths. The diff adds no experimental feature, changes no `apis/*…
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
nix.shstarteddockerdfrom the bind-mounted checkout, so a crashing child process with a relativecore_patterndumped core into the user's repo. On macOS with Rancher Desktop (Rosetta), BuildKit's emulator probe crashes at everydockerdstart, leaving an emptycorefile in the repo root.This starts
dockerdfrom/instead. All of its paths are absolute, andnixstill runs from the checkout.Verified:
./nix.sh flake checkpasses, and nocorefile appears.I have:
./nix.sh flake checkto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.
🤖 Generated with Claude Code