Add digests.Options and set one up inside c/image/copy
#530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
Dec 5, 2025
| // only to allow gradually building the feature set. | ||
| // After c/image/copy consistently implements it, provide a public digest options API of some kind. | ||
| optionsCopy := *options | ||
| optionsCopy.digestOptions = digests.CanonicalDefault() |
Contributor
Author
There was a problem hiding this comment.
For experiments, this can be modified to refer to storage/pkg/supported-digests/algorithm.go or be hard-coded to digests.MustUse(digests.SHA512).
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 5, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6572 |
This was referenced Dec 5, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 5, 2025
The goal is to allow building the digest-choice-dependent machinery from the bottom up without committing to an API while we don't understand the problem space; for now, we don't expose any way for users to actually make a choice. This code is never called at this point, so this should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
for now, purely to let us internally work on implementing digest choice / conversions; there is no way for a caller to set it. Should not change behavior, the field has no users. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #512 , just to have a shared setup in which to work on c/image/copy.
@lsm5 PTAL.
I have left out the actual
PutBlobchange from #512, I want that to actually be implemented in all transports at once — so #512 might be more convenient to experiment on.