WIP: BROKEN sketch at how digest choice might work for c/image/copy
#512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
Nov 29, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 29, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6552 |
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 3, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 3, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 5, 2025
Contributor
Author
|
This is now on top of #530 . I think I’d like to go one consistent step at a time: in this case, if this is extending |
The goal is to allow building the digest-choice-dependent machinery from the bottom up without committing to an API while we don't understand the problem space; for now, we don't expose any way for users to actually make a choice. This code is never called at this point, so this should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
for now, purely to let us internally work on implementing digest choice / conversions; there is no way for a caller to set it. Should not change behavior, the field has no users. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is: - UNUSABLE (no external API) - INCOMPLETE (manifest digests, TryReusingBlob, ...) - BROKEN (various code assumes that digest returned from upload matches input) - INCONSISTENT (PutBlobOptions.Digests is only implemented in one transport, and silently ignored elsewhere) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
choose-digest
branch
from
cf97f48 to
25d5ffc
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsm5 I’m thinking something vaguely like this will be necessary to support #375 (comment) , depending on users’ desires:
--preserve-digests)I don’t know whether we want to expose all of these options to users, but I do think we must make the algorithm choice based on source image+
cannotModify…+user options, and this might be a possible way to structure that.Warning: c/image/copy continues to make assumptions that would be broken by changing a digest algorithm during copy. This is unusable as is. I didn’t run the code at all.