Repository navigation
A Note queued offline is made once, even if the page closes mid-send; no flaky e2e; dead helpers gone - #112
Merged
Merged
Conversation
… no flaky e2e; dead helpers and launch-placeholder notes gone Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two flaky e2e tests, both fixed, and a small cleanup before the repo goes public.
A Note queued offline could be made twice (real bug). If a page closed or reloaded while its queue was sending, the server could make the Note while the page never heard back. The Note stayed queued and was sent again on the next load.
notes-and-many.spec.ts:68caught this 1 or 2 times in 5, on main as well.CreateItemBodytakes an optionalclientKey. A Note, Todo or Thing with a key the account has already used returns the first item (created: false) instead of making another. A unique partial index on(userId, clientKey)covers two copies arriving at once.@pluck/client(extension and iPhone) sends each entry's id the same way.createTextItemreturns{ item, created }. There's a new two-user test: a resend, two sends at once, and another person using the same key.extension.spec.ts:160(sign out, then the popup asks to sign in). It opened the popup before sign-out had finished revoking and clearing the tokens. It now waits for "Signed out." first.Cleanup:
sourceLabelandMOVEDfromshared-schemas/format.ts, English helpers nothing uses since the move to catalogs.CLONE_URLintoREPO_URL.I also checked that no env file, key or password is in any commit on any branch, and that every file path the docs mention exists.
Checks, run locally: typecheck, lint, 444 unit tests, and
pnpm design(0 anti-patterns).🤖 Generated with Claude Code
https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7