Skip to content

fix: cover update fails #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7eliassen wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: cover update fails #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/domain/service/noteSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@ export default class NoteSettingsService {
* In this case we need to remove previous cover
*/
if (notEmpty(data.cover) && notEmpty(noteSettings.cover)) {
await this.shared.fileUploader.deleteFile(noteSettings.cover);
try {
await this.shared.fileUploader.deleteFile(noteSettings.cover);
} catch (error) {
this.logger.warn('Previous cover not deleted', { err: error });

@neSpecc neSpecc Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to take a look at logs after the release and find out the reason why previous file could not be deleted

}
Comment on lines +146 to +150

this.logger.debug('Note cover replaced', {
noteId,
Expand Down
Loading