fix: cover update fails#302
Open
7eliassen wants to merge 1 commit into
Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
neSpecc
approved these changes
Jun 10, 2026
neSpecc
reviewed
Jun 10, 2026
| try { | ||
| await this.shared.fileUploader.deleteFile(noteSettings.cover); | ||
| } catch (error) { | ||
| this.logger.warn('Previous cover not deleted', { err: error }); |
Member
There was a problem hiding this comment.
We need to take a look at logs after the release and find out the reason why previous file could not be deleted
There was a problem hiding this comment.
Pull request overview
This PR updates the note settings patch flow to prevent cover updates from failing when deletion of the previous cover file record errors (e.g., missing files table entry), improving robustness of cover replacement.
Changes:
- Wraps
fileUploader.deleteFilefor the previous cover in atry/catchso deletion failures don’t abortpatchNoteSettingsByNoteId. - Logs a warning when previous cover deletion fails, then proceeds with updating the cover setting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+146
to
+150
| try { | ||
| await this.shared.fileUploader.deleteFile(noteSettings.cover); | ||
| } catch (error) { | ||
| this.logger.warn('Previous cover not deleted', { err: error }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When updating a note cover, the API deletes metadata about the previous cover stored in the
filestable. If no such record exists, the program throws an error (File not found) and thecoverfield in note settings is not updated.What was done
Added error handling for
FileUploader.deleteFilecall inpatchNoteSettingsByNoteId. Deletion errors are logged as warnings and no longer interrupt the flow.