Skip to content

Fixing alt text WCAG violations in anticipation of VPAT #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannahbergam merged 2 commits into from
Jan 23, 2026
Merged

Fixing alt text WCAG violations in anticipation of VPAT #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b218645
adding empty alt text
hannahbergam Jan 23, 2026
5e00aba
adding alt text to the rest of the repo
hannahbergam Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/oceans/components/common/ConfirmationDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ let UnwrappedConfirmationDialog = class ConfirmationDialog extends React.Compone
<div style={styles.confirmationDialogBackground}>
<div style={styles.confirmationDialog}>
<div style={styles.confirmationDialogContent}>
<img src={snail} style={styles.confirmationDialogImg}/>
<img src={snail} style={styles.confirmationDialogImg} alt=""/>
<div>
<div
style={styles.confirmationHeader}
Expand Down
1 change: 1 addition & 0 deletions src/oceans/components/common/Guide.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ let UnwrappedGuide = class Guide extends React.Component {
...styles.guideArrow,
...styles[`arrow${currentGuide.arrow}`]
}}
alt=""
Copy link
Contributor Author

@hannahbergam hannahbergam Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a visual guide which is unhelpful anyway for a nonsighted person. The rest of the guide images already had empty alt text.

/>
)}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/oceans/components/common/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Content.propTypes = {

const Loading = () => (
<Body>
<img src={loadingGif} style={styles.loading} />
<img src={loadingGif} style={styles.loading} alt="Loading"/>
</Body>
)

Expand Down
2 changes: 1 addition & 1 deletion src/oceans/components/scenes/pond/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ let UnwrappedPond = class Pond extends React.Component {
<FontAwesomeIcon icon={faInfo} style={styles.infoIcon} />
</div>
)}
<img style={styles.pondBot} src={aiBotClosed} />
<img style={styles.pondBot} src={aiBotClosed} alt=""/>
{state.canSkipPond && (
<div id="uitest-nav-btns">
{state.appMode === AppMode.FishLong ? (
Expand Down
5 changes: 3 additions & 2 deletions src/oceans/components/scenes/train/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@ let UnwrappedTrain = class Train extends React.Component {
styles.trainBotHead,
this.state.headOpen && styles.trainBotOpen
]}
alt=""
/>
<img src={aiBotBody} style={styles.trainBotBody} />
<img src={aiBotBody} style={styles.trainBotBody} alt=""/>
</div>
<div style={styles.counter}>
<img src={counterIcon} style={styles.counterImg} />
<img src={counterIcon} style={styles.counterImg} alt=""/>
<span style={styles.counterNum} id="uitest-train-count">
{Math.min(999, state.yesCount + state.noCount)}
</span>
Expand Down