Skip to content

sql: alter column identity with the declarative schema changer #157030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sql: alter column identity with the declarative schema changer #157030

wants to merge 3 commits into from

Conversation

@bghal
Copy link
Contributor

@bghal bghal commented Nov 6, 2025 •
edited
Loading

Adds support for the ALTER COLUMN ... [RESTART | SET [CACHE | CYCLE | ... ] identity operations in the declarative schema changer.

Fixes:#142914
Epic: CRDB-31283

Release note (sql change): The ALTER COLUMN ... sequence identity
commands are run by the declarative schema changer.

@blathers-crl
Copy link

blathers-crl bot commented Nov 6, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 6, 2025

This change is Reviewable

@bghal bghal force-pushed the sc-column-sequence-identity branch 2 times, most recently from 5fb6b01 to 95ba509 Compare November 7, 2025 19:37
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 7, 2025
@bghal bghal force-pushed the sc-column-sequence-identity branch from 95ba509 to f9aa939 Compare November 10, 2025 20:30
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@bghal bghal force-pushed the sc-column-sequence-identity branch from f9aa939 to d17f0de Compare November 17, 2025 16:34
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@bghal bghal force-pushed the sc-column-sequence-identity branch from d17f0de to 6ee6004 Compare November 18, 2025 15:45
@bghal bghal changed the title sql: add column identity sequence options to schema changer sql: alter column identity with the declarative schema changer Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@bghal bghal force-pushed the sc-column-sequence-identity branch from 6ee6004 to cff31c9 Compare November 18, 2025 19:06
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@bghal bghal force-pushed the sc-column-sequence-identity branch from cff31c9 to a7020d6 Compare November 18, 2025 21:40
@bghal
sql: use new increment when restarting sequence
47e7cde 
Previously, if a sequence were restarted and its increment updated in
the same transaction (command), the old increment would be used to set
the value in KV.
This change corrects the `ALTER` DDL to use the new increment value.

Informs: cockroachdb#142914
Informs: cockroachdb#21564

Epic: CRDB-31283

Release note (sql change): Restarting a sequence with an updated
increment has the expected initial value.
@bghal bghal force-pushed the sc-column-sequence-identity branch from a7020d6 to 11f60f1 Compare November 19, 2025 18:15
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@bghal bghal added the O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful label Nov 19, 2025
bghal added 2 commits November 19, 2025 15:22
@bghal
sql/schemachanger: rename sequence option mutation
3c9acd4 
This operation covers a single option not multiple.

Part of: cockroachdb#142914
Epic: CRDB-31283

Release note: None
@bghal
sql: alter column identity with the declarative schema changer
1a00e73 
Adds support for the `ALTER COLUMN ... [RESTART | SET [CACHE | CYCLE |
... ]` identity operations in the declarative schema changer.

Fixes: cockroachdb#142914
Epic: CRDB-31283

Release note (sql change): The `ALTER COLUMN ...` sequence identity
commands are run by the declarative schema changer.
@bghal bghal force-pushed the sc-column-sequence-identity branch from 11f60f1 to 1a00e73 Compare November 19, 2025 20:51
@bghal bghal marked this pull request as ready for review November 19, 2025 21:04
@bghal bghal requested review from a team as code owners November 19, 2025 21:04
@bghal bghal requested review from mgartner and removed request for a team November 19, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgartner mgartner Awaiting requested review from mgartner mgartner is a code owner automatically assigned from cockroachdb/sql-queries-prs

Assignees

No one assigned

Labels

O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bghal @cockroach-teamcity