sql: add column identity sequence options to schema changer

TODO:

Fixes: #142914
Epic: CRDB-31283

Release note (sql change): The `ALTER COLUMN ...` sequence identity
commands are run by the declarative schema changer.

Author: bghal

pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go

@@ -148,7 +148,7 @@ func alterSequenceImpl(
 	//
 	// The code below handles the second case.
 
-	if opts.Increment < 0 && (oldIncrement != seqDesc.SequenceOpts.Increment || oldMinValue != seqDesc.SequenceOpts.MinValue) {
+	if opts.Increment < 0 && (oldIncrement != seqDesc.SequenceOpts.Increment || seqDesc.SequenceOpts.MinValue < oldMinValue) {
 		// Only get the sequence value from KV if it's needed.
 		sequenceVal, err := getSequenceValue()
 		if err != nil {

pkg/ccl/logictestccl/tests/local-read-committed/generated_test.go

@@ -274,3 +274,21 @@ func AssignSequenceOptions(
 	}
 	return nil
 }
+
+// DefaultSequenceOptions is a helper that returns the default sequence options.
+// It panics on error.
+func DefaultSequenceOptions() descpb.TableDescriptor_SequenceOpts {
+	defaultOpts := descpb.TableDescriptor_SequenceOpts{
+		Increment: 1,
+	}
+	if err := AssignSequenceOptions(&defaultOpts,
+		nil, /* optsNode */
+		64,
+		true, /* setDefaults */
+		nil,  /* existingTypes */
+	); err != nil {
+		panic(err)
+	}
+
+	return defaultOpts
+}

pkg/ccl/logictestccl/tests/local-repeatable-read/generated_test.go

@@ -4362,9 +4362,6 @@ RESET create_table_with_schema_locked
 
 subtest end
 
-statement ok
-SET create_table_with_schema_locked=false
-
 statement ok
 CREATE TABLE t_alter_identity (id SERIAL PRIMARY KEY, a int GENERATED ALWAYS AS IDENTITY, b int GENERATED ALWAYS AS IDENTITY, z int);
 
@@ -4377,7 +4374,7 @@ ALTER TABLE t_alter_identity ALTER COLUMN b SET MAXVALUE 10 SET START WITH 11;
 query error pq: START value \(5\) cannot be less than MINVALUE \(10\)
 ALTER TABLE t_alter_identity ALTER COLUMN b SET MINVALUE 10 SET START WITH 5;
 
-query error pq: column "z" of relation "t_alter_identity" is not an identity column
+query error pq: cannot alter identity of a non-sequence column "z"
 ALTER TABLE t_alter_identity ALTER COLUMN z SET START WITH 5;
 
 # Verify sequence options are implemented on the identity
@@ -4401,7 +4398,7 @@ statement ok
 INSERT INTO t_alter_identity DEFAULT VALUES;
 
 statement ok
-ALTER TABLE t_alter_identity ALTER COLUMN b SET MAXVALUE 40 RESTART WITH 20 SET CACHE 5 SET INCREMENT BY 2
+ALTER TABLE t_alter_identity ALTER COLUMN b SET MAXVALUE 40 RESTART WITH 20 SET CACHE 5 SET INCREMENT BY 2;
 
 statement ok
 INSERT INTO t_alter_identity DEFAULT VALUES;
@@ -4415,8 +4412,83 @@ SELECT b from t_alter_identity ORDER BY b;
 1
 5
 9
-18
 20
+22
+
+subtest issue-52552
+
+statement ok
+CREATE TABLE test_52552_asc (c1 int GENERATED ALWAYS AS IDENTITY);
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET INCREMENT 3 SET MINVALUE 1 SET MAXVALUE 12;
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET INCREMENT 8 SET MINVALUE 1 SET MAXVALUE 12;
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+query I
+SELECT c1 FROM test_52552_asc
+----
+8
+
+statement error pq: reached maximum value of sequence "test_52552_asc_c1_seq" \(12\)
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+statement error pq: reached maximum value of sequence "test_52552_asc_c1_seq" \(12\)
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+statement ok
+ALTER TABLE test_52552_asc ALTER COLUMN c1 SET NO MAXVALUE;
+INSERT INTO test_52552_asc DEFAULT VALUES;
+
+query I nosort
+SELECT c1 FROM test_52552_asc
+----
+8
+32
+
+
+statement ok
+CREATE TABLE test_52552_desc (c1 int GENERATED ALWAYS AS IDENTITY);
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET INCREMENT -5 SET MINVALUE 1 SET MAXVALUE 12;
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET INCREMENT -8 SET MINVALUE 1 SET MAXVALUE 12;
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+query I
+SELECT c1 FROM test_52552_desc
+----
+8
+
+statement error pq: reached minimum value of sequence "test_52552_desc_seq" \(1\)
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+statement error pq: reached minimum value of sequence "test_52552_desc_seq" \(1\)
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+statement ok
+ALTER TABLE test_52552_desc ALTER COLUMN c1 SET NO MINVALUE;
+INSERT INTO test_52552_desc DEFAULT VALUES;
+
+
+query I nosort
+SELECT c1 FROM test_52552_desc
+----
+-4
+
+
+# 
+# statement ok
+# CREATE SEQUENCE test_52552_start INCREMENT BY 3 MINVALUE 1 MAXVALUE 100 START 50;
+# 
+# statement ok
+# ALTER SEQUENCE test_52552_start INCREMENT BY 8;
+# 
+# query I
+# SELECT nextval('test_52552_start');
+# ----
+# 50
+
+subtest end
+
+statement ok
+SET create_table_with_schema_locked=false
 
 statement ok
 CREATE TABLE t_identity_drop (a int GENERATED ALWAYS AS IDENTITY (START WITH 10), b int GENERATED BY DEFAULT AS IDENTITY);