Skip to content

Conversation

@skdud4659
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

piggggggggy and others added 26 commits January 16, 2025 15:19
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
* chore(user-account-page): edit some design changes

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
feat: merge to master (apply alert-manager- v2 branch)
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
chore(event-rule): apply 'hasReadWriteAccess' at order button
feat(dashboard-qa): merge to master
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
feat: apply reference store data at service item, alert detail summary
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…d page

Signed-off-by: samuel.park <samuel.park@megazone.com>
chore(reset-password): apply new update password api to reset-password page
feat: apply escalation policy link
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 20, 2025
@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 6:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Jan 20, 2025 6:58am
inventory-v2 ⬜️ Ignored (Inspect) Jan 20, 2025 6:58am

@github-actions
Copy link
Contributor

⚠️ @skdud4659 the signed-off-by was not found in the following 6 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@github-actions github-actions bot requested review from Hansoo-mzc and sulmoJ January 20, 2025 06:58
@cloudforet-io cloudforet-io deleted a comment from github-actions bot Jan 20, 2025
@skdud4659 skdud4659 merged commit a847fd7 into develop Jan 20, 2025
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants