Skip to content

Conversation

@skdud4659
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

WANZARGEN and others added 30 commits January 14, 2025 22:12
…5521)

* chore: for ci test

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: add check for PR author organization membership and assign them

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: update pull request review labeler to handle reopened events

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: enhance pull request review labeler to handle missing review state

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

---------

Signed-off-by: Wanjin Noh <wanjin@megazone.com>
Signed-off-by: Wanjin Noh <wanjin@megazone.com>
…rsion (#5536)

- Inverted the condition for determining the collector and region fetchers
- Ensured correct API client is used based on alert manager version

Signed-off-by: sulmo <sulmo@megazone.com>
…ject-alert-manager

Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* chore: changed icon color

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: create alert creation button at service page

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: update history error modal

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: create app reference store and apply app name at timeline

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply resource link at alert detail page

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply 'user group' text at member modal

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply raw data modal at webhook error tab

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: fixed timeline bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply filter retention

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: changed translations and style

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: changed create alert button position

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: fixed condition form bug and translate operator

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* fix: fixed minor bug (timeline)

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: fixed qa bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
feat: apply master to develop
…ject-alert-manager

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…anged-planning

fix(user-account-page): apply changed planning (password-check, set mfa)
* feat: fix undefined properties error of user page at admin mode

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update escalation policy data table information

add channel information per step & finish condition

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* fix: change unnecessary code that already exists

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

---------

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* refactor: changing resizer line to fatter when it hoverd
---------

Signed-off-by: daeyeon ko <rowan@megazone.com>
- Reordered `targetRef`, `menuRef`, and `inputRef` declarations
- Passed `targetRef` and `menuRef` to `useContextMenuStyle` function

Signed-off-by: sulmo <sulmo@megazone.com>
fix: reflect the latest changes in composable to the queryInput

Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
…assignment behavior (#5578)

* ci: update pull request review state labeler permissions to allow writing issues and pull requests

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: enhance pull request review not to add pending label when reviewer is already selected

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* Revert "ci: enhance pull request review not to add pending label when reviewer is already selected"

This reverts commit 14773ff.

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

* ci: enhance pull request reviewer assignment workflow

Signed-off-by: Wanjin Noh <wanjin@megazone.com>

---------

Signed-off-by: Wanjin Noh <wanjin@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: Wanjin Noh <wanjin@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
skdud4659 and others added 12 commits January 21, 2025 22:45
…ject-alert-manager

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* feat: update translations

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: update alert public page with v2 division

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: update title not to be displayed if there's no data

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: fix bug about hasReadWriteAccess of button

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: remove unnecessary condition in template

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update alertModelV2 usage from alert-manager model

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update title not to be displayed if there's no alertServiceList

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

---------

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…ject-alert-manager

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
…orer/cost-analysis/dashboard (#5577)

* feat: create group by filter constant

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(dashboard): add project group variable preset

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(cost-query-set): apply changed filter schema to managed query set

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(cost-filter-item): apply group-by filter constant to filter item hook

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat: apply project group filtering to metric group by

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
…tric-explorer) (#5586)

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

* fix(metric-explorer): apply custom project group filter

Signed-off-by: samuel.park <samuel.park@megazone.com>

* fix(widget-filter): apply project-group filter to data-table form

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
* feat: add custom css of component because of minor bug

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update schedule setting form reactivity

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update disabled state of button if no data

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

---------

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
* feat: apply qa

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 22, 2025
@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Jan 22, 2025 1:58am
dashboard ⬜️ Ignored (Inspect) Jan 22, 2025 1:58am
inventory-v2 ⬜️ Ignored (Inspect) Jan 22, 2025 1:58am

@github-actions
Copy link
Contributor

⚠️ @skdud4659 the signed-off-by was not found in the following 3 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@cloudforet-io cloudforet-io deleted a comment from github-actions bot Jan 22, 2025
@skdud4659 skdud4659 merged commit a0f9d57 into master Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants