C# release changes for cargo release
#3648
Conversation
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
13dd2c8 to
f514b08
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
f514b08 to
909a8fc
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
2bebcd4 to
0e8c87a
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
|
Some missing or dangling .meta found. Fix commits are needed.
|
sdks/csharp/release~/spacetimedb.bsatn.runtime/unversioned/.gitignore
Outdated
Show resolved
Hide resolved
…tignore Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
Can you also remove the files from sdks/csharp/packages? They are stale since we're no longer updating them, and then I believe many of these files will show up as moved.
Also, I think we should probably gitignore them, so that devs iterating locally on sdks/csharp will not constantly have dirty working directories.
| logo.png | ||
| spacetimedb.bsatn.runtime.*.nupkg* | ||
| spacetimedb.bsatn.runtime.nuspec | ||
| *.xml |
There was a problem hiding this comment.
as an aside.. to we expect any of these files to actually appear down here?
There was a problem hiding this comment.
This .gitignore file gets included when we copy unversioned to a versioned directory (e.g. 1.10.0). Then the release step of actually copying the DLL files is a bit easier because we just copy the output of the dotnet pack into this directory and when we git add && git commit we don't have to worry about accidentally committing these files. I could update the release flow to only git commit the required files instead of doing a git commit on the directory - what do you prefer?
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
…ckworklabs/SpacetimeDB into jdetter/csharp-release-changes
|
@bfops I removed everything under |
|
Some missing or dangling .meta found. Fix commits are needed.
|
Description of Changes
This adds the new "skeleton" directory that we use for
cargo release.API and ABI breaking changes
None
Expected complexity level and risk
1 - this is just a release change
Testing
1.8.0and1.9.0release and we'll also be using it for the1.10.0release.