Skip to content

fix: prefer relocated source path suffixes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylandreimerink merged 1 commit into from
Aug 17, 2026
Merged

fix: prefer relocated source path suffixes #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/stackwhere/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,17 @@ func (wa *webApp) resolveSourcePath(requestedPath string) (string, bool) {
candidates := make([]string, 0, len(wa.sourceDirs))
if filepath.IsAbs(cleanPath) {
candidates = append(candidates, cleanPath)

pathWithoutVolume := strings.TrimPrefix(cleanPath, filepath.VolumeName(cleanPath))
parts := strings.FieldsFunc(pathWithoutVolume, func(r rune) bool {
return r == rune(filepath.Separator)
})
for i := range parts {
suffix := filepath.Join(parts[i:]...)
for _, sourceDir := range wa.sourceDirs {
candidates = append(candidates, filepath.Join(sourceDir, suffix))
}
}
} else {
for _, sourceDir := range wa.sourceDirs {
candidates = append(candidates, filepath.Join(sourceDir, cleanPath))
Expand Down
37 changes: 37 additions & 0 deletions cmd/stackwhere/web_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,43 @@ func TestWebHandlerServesSourcePage(t *testing.T) {
}
}

func TestWebHandlerPrefersRelocatedSourcePath(t *testing.T) {
sourceDir := t.TempDir()
for _, dir := range []string{"a", "src"} {
if err := os.Mkdir(filepath.Join(sourceDir, dir), 0o755); err != nil {
t.Fatalf("failed to create source directory: %v", err)
}
}

if err := os.WriteFile(filepath.Join(sourceDir, "a", "basic.c"), []byte("int wrong_source;\n"), 0o644); err != nil {
t.Fatalf("failed to write wrong source file: %v", err)
}
if err := os.WriteFile(filepath.Join(sourceDir, "src", "basic.c"), []byte("int expected_source;\n"), 0o644); err != nil {
t.Fatalf("failed to write expected source file: %v", err)
}

app, err := newWebApp("../../testdata/basic.o", []string{sourceDir})
if err != nil {
t.Fatalf("failed to initialize web app: %v", err)
}

req := httptest.NewRequest("GET", "/source?file=%2Fsrc%2Fbasic.c", nil)
rr := httptest.NewRecorder()
app.handler().ServeHTTP(rr, req)

if rr.Code != 200 {
t.Fatalf("unexpected status code: got %d want 200", rr.Code)
}

body := rr.Body.String()
if !strings.Contains(body, "expected_source") {
t.Fatalf("expected relocated source file, got %q", body)
}
if strings.Contains(body, "wrong_source") {
t.Fatalf("unexpected basename-only source match, got %q", body)
}
}

func TestWebHandlerSourcePageNotFound(t *testing.T) {
app, err := newWebApp("../../testdata/basic.o", nil)
if err != nil {
Expand Down