Skip to content

fix: prefer relocated source path suffixes - #20

Merged
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix/web-source-suffix
Aug 17, 2026
Merged

fix: prefer relocated source path suffixes#20
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix/web-source-suffix

Conversation

@immanuwell

@immanuwell immanuwell commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Absolute DWARF paths can fall back to the first matching basename in web.
With both a/basic.c and src/basic.c, a /src/basic.c link shows a/basic.c

The resolver now tries relocated path suffixes first, then keeps the basename fallback

Repro:

  1. Put different files at a/basic.c and src/basic.c
  2. Run stackwhere web collection.o --source-dir .
  3. Open /source?file=%2Fsrc%2Fbasic.c

Before it picks a/basic.c, now it picks src/basic.c

Tests: go test ./..., go test -race ./..., go vet ./..., golangci-lint run

Signed-off-by: immanuwell <pchpr.00@list.ru>
@dylandreimerink
dylandreimerink merged commit 1beb2ce into cilium:main Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants