Fixed m4/cf3_gcc_flags.m4 to actually test compiler flags - #6252
Open
craigcomstock wants to merge 3 commits into
Open
Fixed m4/cf3_gcc_flags.m4 to actually test compiler flags#6252craigcomstock wants to merge 3 commits into
craigcomstock wants to merge 3 commits into
Conversation
This was broken in CFE-3629 in commit fc40dd6 Ticket: ENT-14382 Changelog: none
craigcomstock
marked this pull request as ready for review
July 29, 2026 20:29
larsewi
requested changes
Jul 30, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
you save_CFLAGS="$CFLAGS" conditionally (inside the if block), and restore it unconditionally (outside the if block). Meaning you will remove all the flags unless test x"$GCC" = "xyes" && test x"$HP_UX_AC" != x"yes".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in CFE-3629 in commit fc40dd6
Ticket: ENT-14382
Changelog: none
together
#6252
https://github.com/cfengine/enterprise/pull/988
https://github.com/cfengine/nova/pull/2670