Fixed m4/cf3_gcc_flags.m4 to actually test compiler flags - #286
Open
craigcomstock wants to merge 2 commits into
Open
Fixed m4/cf3_gcc_flags.m4 to actually test compiler flags#286craigcomstock wants to merge 2 commits into
craigcomstock wants to merge 2 commits into
Conversation
Previously the compile check was not using any CFLAGS to test if the compile flags were supported. This was broken for CFE-3629 in commit 257982d Ticket: ENT-14382 Changelog: none
Contributor
Author
|
|
Contributor
Author
|
bad core PR to test with, here's a new build that should work: |
Contributor
Author
|
This does seem to work for hpux: I am testing for all platforms with the change in the other repositories that have this macro now: |
Contributor
Author
the badges are not working well... the above is green/passing. |
craigcomstock
marked this pull request as ready for review
July 29, 2026 20:28
|
There was an error running your pipeline, see logs for details. |
larsewi
requested changes
Jul 30, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Same as cfengine/core#6252 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the compile check was not using any CFLAGS to test if the compile flags were supported.
Ticket: ENT-14382
Changelog: none