Repository navigation
fix(deps): pin idna below 3.20, which ignores transitional processing - #355
Closed
KaiSchwarz-cnic wants to merge 2 commits into
Closed
KaiSchwarz-cnic wants to merge 2 commits into
KaiSchwarz-cnic wants to merge 2 commits into
Conversation
idna 3.20 turns uts46_remap(transitional=True) into a no-op that only warns, so IDNAProcessor silently stops mapping e.g. faß.de to fass.de for the TLDs it treats as transitional. Registries have not converged on one IDNA standard, so the SDK keeps that behaviour. Refs: RSRMID-3125
Refs: RSRMID-3125
Contributor
Author
|
Superseded: the pin here is one version too late. idna 3.19 already ignores transitional processing, and CI still failed with 3.19 installed. Replaced by the PR from RSRMID-3125-pin-idna-3.18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: RSRMID-3125
idna 3.20 makes
uts46_remap(transitional=True)deprecated and ignored: it only warns.IDNAProcessorrelies on it for the TLDs it treats as transitional, so with 3.20faß.deencodes asxn--fa-hia.deinstead offass.de. That is whytests/test_idnaconverter.pyfails on every open Dependabot PR (e.g. #353). Fresh installs of the released SDK already resolve to 3.20 underidna>=3.19.Registries have not converged on one IDNA standard (2003, 2008, UTS #46), so the SDK keeps its per-TLD transitional behaviour:
fix(deps): pinidna>=3.19,<3.20. This triggers a release, so users get the pin.ci(dependabot): ignore idna>=3.20, so Dependabot stops proposing bumps the pin would reject. fix(deps): update idna requirement from >=3.19 to >=3.20 #347 (idna 3.20) gets closed once this merges.🤖 Generated with Claude Code